Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the spaces on url comments #126

Closed
wants to merge 1 commit into from
Closed

remove the spaces on url comments #126

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 28, 2022 •
edited by ghost

Make sure it is perfectly aligned with # marks

@google-cla
Copy link

google-cla bot commented Jun 28, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ghost ghost closed this Jun 28, 2022
@ghost ghost reopened this Jun 30, 2022
ashie pushed a commit to clear-code/chromium that referenced this pull request Jul 13, 2022
Lazily load extensions::IndividualSettings.
5dc914b 
In a Chrome-branded release build on corp this reduces startup time by
half (1s->0.5s) and browser process memory by nearly a half (160MB->85MB).

Put this behind an enabled-by-default Finch experiment so we can:
1) measure the effectiveness from our users
2) disable it quickly if we see any issues

(cherry picked from commit 20abe8b)

Bug: 1256913, 1258809, 1257547
Change-Id: I92f3a3b35f87ba7b80a90d5e794c1f3b70b0c7d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3206863
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#931228}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223513
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/branch-heads/4664@{chromium#126}
Cr-Branched-From: 24dc4ee-refs/heads/main@{#929512}
aarongable pushed a commit that referenced this pull request Jul 20, 2022
@bungeman
Roll src/third_party/freetype-testing/src/ fe2eddae6..1ca0c99d2 (17 c…
1994caa 
…ommits)

https://chromium.googlesource.com/external/github.com/freetype/freetype2-testing.git/+log/fe2eddae6176..1ca0c99d25ae

$ git log fe2eddae6..1ca0c99d2 --date=short --no-merges --format='%ad %ae %s'
2022-05-23 drott Track VisitedSet at top level before colrv1_start_glyph (#127)
2022-01-11 bungeman Unquote cc and cxx when executing. (#126)
2022-01-09 bungeman Quote more strings. (#125)
2022-01-09 bungeman Build bzip2 correctly. (#124)
2022-01-06 bungeman Use CC and CXX, check for clang version. (#123)
2022-01-06 bungeman Allow ubsan with asan or by itself. (#122)
2021-12-29 bungeman Remove CMAKE_x_COMPILER from libcxx build. (#119)
2021-12-24 bungeman Drop support for git <= 2.14. (#112)
2021-12-24 bungeman Make --rebuild work correctly again. (#111)
2021-12-24 bungeman Use sanitize-coverage=0 not no-sanitize-coverage (#115)
2021-12-24 bungeman Choose exactly one of the exclusive fuzzers (#117)
2021-12-24 bungeman Add missing quotes to libcxx.sh (#116)
2021-12-18 bungeman Add trace-pc-guard to no-sanitize-coverage. (#114)
2021-12-16 bungeman Add llvm-project for MemorySanitizer build. (#113)
2021-12-10 bungeman Add MemorySanitizer build option. (#110)
2021-11-09 drott Update corpus files for COLRv1 again (#109)
2021-11-01 drott Update corpus files for COLRv1 (#108)

Created with:
  roll-dep src/third_party/freetype-testing/src

Change-Id: I358febbaa1933d6d56ad655f62702d67e4a6c0c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3777978
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1026318}
darinwf pushed a commit to neevaco/chromium that referenced this pull request Aug 10, 2022
@mitoshima @SumaliSonchai
Revert "[m104] Only notify when size acutally changed in OnHostResize…
8f07b74 
…dInPixels"

This reverts commit 965f7ea.

Reason for revert: causing regression crbug.com/1336548

Original change's description:
> [m104] Only notify when size acutally changed in OnHostResizedInPixels
>
> This method is called also when the scale factor MAY change and may not
> results in the actual size change. In that case, we should not call
> the observer which may close auto fill window.
>
> This CL intentionally still try to update the compositor to minimize the
> risk of merging back to m104.
>
> Bug: 1329481
> Test: covered by unittest.
>
> (cherry picked from commit 6038cd3)
>
> Change-Id: I851e59b6178e46e1d4a4e7117c340f38190cc6ca
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3704961
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
> Cr-Original-Commit-Position: refs/heads/main@{#1014083}
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3707553
> Commit-Queue: Scott Violet <sky@chromium.org>
> Auto-Submit: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/branch-heads/5112@{chromium#80}
> Cr-Branched-From: b13d3fe-refs/heads/main@{#1012729}

Bug: 1329481
Change-Id: I75c5844a08b87e3cf071637a9e80cb48b26bef1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3712180
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5112@{chromium#126}
Cr-Branched-From: b13d3fe-refs/heads/main@{#1012729}
@ghost
Copy link
Author

ghost commented Aug 29, 2022

it's a mirror ahhhhhhhh

@ghost ghost closed this Aug 29, 2022
blueboxd referenced this pull request in blueboxd/chromium-legacy Aug 31, 2022
M105: Set feed query URL for app-close refresh
16bd415 
Also remove the "default" case so that the compiler will catch unhandled RequestReasons in the future.

(cherry picked from commit 9d56f47)

Bug: b/240479263, 1348279
Change-Id: Ibf4c7e3d5426a51639783d860af9d406bc21450f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3790224
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Auto-Submit: Ian Wells <iwells@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1029478}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3792356
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5195@{#126}
Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
blattersturm pushed a commit to citizenfx/chromium that referenced this pull request Aug 31, 2022
[lacros skew tests] Refresh skew tests for M104 M102
a2da5ca 
This CL updates the ash version ['104.0.5072.0', '102.0.5005.56'] for Lacros version skew testing.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org,
yjt@google.com.

R=rubber-stamper@appspot.gserviceaccount.com

Bug: None
Change-Id: Ib36121cd619e2651cc2912c420865759cd0ffc77
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3653946
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5060@{chromium#126}
Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
blueboxd referenced this pull request in blueboxd/chromium-legacy Sep 29, 2022
Fix side panel resize RTL bug
52c73a0 
Takes UI direction into account when determining whether side panel
should display and act as if it is placed on the left vs. the right.

(cherry picked from commit 81c9104)

Bug: 1355265
Change-Id: If95606af82e42bec8db7ea61cfbce9d9d768e942
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3848741
Commit-Queue: Emily Shack <emshack@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1038841}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3857191
Auto-Submit: Emily Shack <emshack@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/branch-heads/5249@{#126}
Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}
blueboxd referenced this pull request in blueboxd/chromium-legacy Oct 28, 2022
[iOS] Fix scroll position when dismissing feed promo
8bb81db 
(cherry picked from commit 5cb7327)

Fixed: 1363603
Change-Id: I07daea9b15f5dbeb4ac2279f56bad12c6d23095b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3908434
Commit-Queue: Adam Arcaro <adamta@google.com>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1049696}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914674
Auto-Submit: Adam Arcaro <adamta@google.com>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/branch-heads/5304@{#126}
Cr-Branched-From: 5d7b1fc-refs/heads/main@{#1047731}
blueboxd referenced this pull request in blueboxd/chromium-legacy Nov 30, 2022
@rkgibson2
[iOS] Don't remove non-existent credentials on update
8ada456 
This is meant to propagate updates from the source-of-truth (the
PasswordStore) into the credential provider service. If the identifier
doesn't exist in the credential provider service, then there's no need
to delete it.

(cherry picked from commit c1617cf)

Fixed: 1370113, 1372850
Change-Id: I631cfbdc66985b27dbedf6f4b544a7fdf5cb7a04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3961450
Reviewed-by: David Jean <djean@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1060460}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3963806
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Robbie Gibson <rkgibson@google.com>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/branch-heads/5359@{#126}
Cr-Branched-From: 27d3765-refs/heads/main@{#1058933}
wendachuan pushed a commit to wendachuan/chromium that referenced this pull request Jan 7, 2023
[Autofill] Add metric IsSubmittedValueSameAsAutofillableValue
a1e1205 
This CL introduces a metric to measure the count of fields that had a
prefilled value and therefore, autofill could not fill the value.
The metrics would tell us in how many cases the submitted value entered
by the user would be same as the value provided by autofill for filling.

(cherry picked from commit 4384cc4)

Bug: 1275649, 1299784
Change-Id: If1e2c2ea8ad3ac150a7c6f8cc94315281168a723
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3461380
Reviewed-by: Matthias Körber <koerber@google.com>
Commit-Queue: Vidhan Jain <vidhanj@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#974182}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3488387
Auto-Submit: Vidhan Jain <vidhanj@google.com>
Commit-Queue: Matthias Körber <koerber@google.com>
Cr-Commit-Position: refs/branch-heads/4896@{chromium#126}
Cr-Branched-From: 1f63ff4-refs/heads/main@{#972766}
MaoHan001 pushed a commit to riscv-android-src/chromium that referenced this pull request Jan 17, 2023
Enable multiple task attribution observers
2c5c407 
(cherry picked from commit 1dc0a2d)

Bug: 1377468
Change-Id: Idb8b3a5ad90022258bb64aea91ee7d13ad9e8242
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4024444
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Scott Haseley <shaseley@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1072552}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4035034
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5414@{chromium#126}
Cr-Branched-From: 4417ee5-refs/heads/main@{#1070088}
wwwppp0801 pushed a commit to wwwppp0801/chromium that referenced this pull request Feb 13, 2023
Allow PrefetchService to block until the head of a prefetch is received
68bad88 
when trying to serve the prefetch.

This CL allows for a prefetch that has been started but waiting on the
head of the response to be served. In this case, PrefetchService will
block until the head of the prefetch is received, then pass it to
PrefetchURLLoaderInterceptor it is servable.

(cherry picked from commit 2e83b5d)

Bug: 1375852
Change-Id: I32a99bfae3fe739020ad1b5313c0a1a8b6c6a82a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4121433
Reviewed-by: Sreeja Kamishetty <sreejakshetty@chromium.org>
Commit-Queue: Max Curran <curranmax@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1087624}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4134704
Auto-Submit: Max Curran <curranmax@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5481@{chromium#126}
Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
chirayudesai pushed a commit to chirayudesai/chromium that referenced this pull request Mar 7, 2023
@michaeldo1
[M111] Add feature flag for preventing navigation
1dfa550 
This new logic was added in crrev.com/c/4206652. Adding a new flag to be
used as a killswitch in case there are any unintended side effects of
this change which are not observed before stable.

(cherry picked from commit 7ab182a)

Bug: 1408799
Change-Id: I22110d7c4a5f1f839c9cb0dd3725e5a854947d5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4215894
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1100500}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4218202
Commit-Queue: Ali Juma <ajuma@chromium.org>
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/branch-heads/5563@{chromium#126}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
calyxos-gerrit pushed a commit to CalyxOS/chromium that referenced this pull request Mar 31, 2023
Roll Amd64 AFDO from 112.0.5615.9_rc-r1-merged to 112.0.5615.12_rc-r1…
53408b7 
…-merged

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file go/crostc-bug.

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-chromium-beta
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I47063bcac0a419cb22604fbd461f9942d87144b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4302670
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5615@{chromium#126}
Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
l0hn pushed a commit to l0hn/chromium_test that referenced this pull request Jun 9, 2023
[Password Manager] Fix console errors related to checkup list item
61b6d66 
This CL fixes an error when group was used before checking it for
undefined.

(cherry picked from commit 8729382)

Bug: 1440042
Change-Id: Id6c2d437204f494d779336cedd9fb1810c538f80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4481257
Auto-Submit: Viktor Semeniuk <vsemeniuk@google.com>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1136503}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4489825
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Cr-Commit-Position: refs/branch-heads/5735@{chromium#126}
Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
msizanoen1 pushed a commit to qtmlabs/chromium that referenced this pull request Jun 29, 2023
Temporarily disable build_allocation_stack_trace_recorder
0e6643b 
Temporarily disable build_allocation_stack_trace_recorder for M116
as it adds performance overhead.

(cherry picked from commit d0d3800)

Bug: 1448009
Change-Id: Ie049c4d1abc99277bc317ece8f84d1d2e4ffa713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625320
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1160478}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4644390
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/branch-heads/5845@{chromium#126}
Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
aetota61 pushed a commit to monkbrowser/monk-browser that referenced this pull request Aug 2, 2023
Privacy Guide: Dynamic PS link visibility
3fe845b 
- Dynamically remove the PS link in the completion step.

(cherry picked from commit 1120cf1)

Bug: 1448806
Change-Id: Ib1359e2b90158bbc78ef2b6a6b183e62c5b0c1fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4567527
Reviewed-by: Nicola Tommasi <tommasin@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Rubin Deliallisi <rubindl@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1149626}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4571028
Auto-Submit: Nicola Tommasi <tommasin@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Nicola Tommasi <tommasin@chromium.org>
Reviewed-by: Rubin Deliallisi <rubindl@chromium.org>
Cr-Commit-Position: refs/branch-heads/5790@{chromium#126}
Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
trflynn89 pushed a commit to RebelBrowser/rebel that referenced this pull request Oct 26, 2023
[iOS] Make interrupt of UserSigninCoordinator more robust
a317813 
This patch changes a little bit the logic to interrupt
UserSigninCoordinator when called with `UIShutdownNoDismiss`.

Now, the coordinator still interrupts the mediator, but the
coordinator doesn't expect a callback from the mediator anymore.
As soon as the mediator is interrupted, the coordinator continues
the interruption workflow by:
+ Dropping the UI (as we are in UIShutdownNoDismiss case)
+ Call the signinCompletion block (to make the sign-in done)
+ Call the interruption completion block.

This patch will be cherry-picked in M118.

(cherry picked from commit d54a8ed)

Fixed: 1474122
Change-Id: Iaff75c4a09abf0e3cbf9fc3f88b05e1deee20491
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4846515
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Menghan Yang <myuu@google.com>
Commit-Queue: Menghan Yang <myuu@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1193962}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4852910
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/branch-heads/5993@{chromium#126}
Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
vuzix-jeff pushed a commit to Vuzix/chromium that referenced this pull request Nov 3, 2023
[3pcd] Add UMA histogram for profile/client eligibility mismatch
b62be1b 
(cherry picked from commit 1eaf2a0)

Bug: 1489403
Change-Id: I379cb6ea846fd68b87156d8f9b08478aaf266bee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4911717
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Anton Maliev <amaliev@chromium.org>
Commit-Queue: Patricia Alfonso <trishalfonso@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1205835}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4916698
Cr-Commit-Position: refs/branch-heads/6045@{chromium#126}
Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
Aikoyori referenced this pull request in Pissandshittium/pissandshittium Dec 8, 2023
Roll Chrome Win64 PGO Profile
36b2a1d 
Roll Chrome Win64 PGO profile from chrome-win64-6099-1698980472-da9f7b15e61499170e953050ff98865dc9f18e67.profdata to chrome-win64-6099-1699009618-c6421b12e4aea3bae95bee37dfc96094b12d5cd8.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m120.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I89ad1fa95d2a84277c6add7654711cd4343ad98e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5004702
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6099@{#126}
Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable pushed a commit that referenced this pull request Jan 6, 2024
Roll Chrome Win64 PGO Profile
6df34dc 
Roll Chrome Win64 PGO profile from chrome-win64-6167-1702015141-625a8a1745906597ce26899135be66c41062514b.profdata to chrome-win64-6167-1702035211-4011e95312ea7dbedd47cf4b1770302146a402fe.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m121.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I11a213927dd0dc8403deae2e38d8283546a06432
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5103850
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6167@{#126}
Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable pushed a commit that referenced this pull request Jan 26, 2024
[M122][ForceSignin] Enable translation for error strings
03e55d7 
(cherry picked from commit 3b130bc)

Bug: 1478217, 1521687
Change-Id: I1f2fea871e9f183c8c830cb3c3e2bd0060565963
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5234135
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Ryan Sultanem <rsult@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1251482}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5236993
Commit-Queue: David Roger <droger@chromium.org>
Auto-Submit: Ryan Sultanem <rsult@google.com>
Cr-Commit-Position: refs/branch-heads/6261@{#126}
Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
aarongable pushed a commit that referenced this pull request Jan 31, 2024
Revert "[M122][ForceSignin] Enable translation for error strings"
c75d9fd 
This reverts commit 03e55d7.

Reason for revert: Translation are not allowed to be merged
back if there is not emergency. These strings are only used in
error messages for relatively rare cases, having them in M123
is ok.

Original change's description:
> [M122][ForceSignin] Enable translation for error strings
>
> (cherry picked from commit 3b130bc)
>
> Bug: 1478217, 1521687
> Change-Id: I1f2fea871e9f183c8c830cb3c3e2bd0060565963
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5234135
> Reviewed-by: David Roger <droger@chromium.org>
> Commit-Queue: Ryan Sultanem <rsult@google.com>
> Cr-Original-Commit-Position: refs/heads/main@{#1251482}
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5236993
> Commit-Queue: David Roger <droger@chromium.org>
> Auto-Submit: Ryan Sultanem <rsult@google.com>
> Cr-Commit-Position: refs/branch-heads/6261@{#126}
> Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}

Bug: 1478217, 1521687
Change-Id: Ie6327d1e3f3d1b93faaf7771f1c63efd92ff961e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5253208
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Ryan Sultanem <rsult@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6261@{#343}
Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
consp1racy pushed a commit to signageos/chromium-chromium that referenced this pull request Feb 21, 2024
@tomasz-wiszkowski
Fix color and RTL positioning of the Dino Widget text
8ace553 
This change addresses regression caused by https://crrev.com/c/3124622
correcting the hot pink text color to correct TextColor.Secondary

The change also addresses an overlooked Text positioning mode for
RTL layouts, warranting that the label is always shown at view start.

(cherry picked from commit 9d75ebd)

Bug: 1249313
Change-Id: I9d51ab0fc59c042c85fe6d1b7568c59d806cbeda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3166010
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Commit-Queue: Sky Malice <skym@chromium.org>
Auto-Submit: Tomasz Wiszkowski <ender@google.com>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#922339}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3169456
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/branch-heads/4638@{chromium#126}
Cr-Branched-From: 159257c-refs/heads/main@{#920003}
aarongable pushed a commit that referenced this pull request Feb 25, 2024
Roll Chrome Linux PGO Profile
82ef9ec 
Roll Chrome Linux PGO profile from chrome-linux-6312-1708794434-0862b42f22acf787f62eb2519b157c0e732f9fc6-242da143989816124f0b7e742cad1fded46f79de.profdata to chrome-linux-6312-1708808042-edab8d2dfcd44bd63b953eb12b366197c4285ede-f826b7851b851ba99af5bdea00ed18e700a5ef3e.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m123.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I89d72cf2335c61044d8d8a02a7ae485ffdfe92dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5322906
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6312@{#126}
Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
NaaeemMalik pushed a commit to SoftwarePrince/Egon-Chromium that referenced this pull request Mar 22, 2024
Quick Delete: UI fixes
49cf850 
Update the dialog UX to fit the UX proposal.

Before: https://screenshot.googleplex.com/AECTkMJNpV8RqFQ
Screenshot (light): https://screenshot.googleplex.com/8BMn46TrFHuiLWg
Screenshot (dark): https://screenshot.googleplex.com/ASmnBnjDmJrLTue

(cherry picked from commit 9f06842)

Bug: 1412087, b/294173198
Change-Id: I2b2f454ad5407768da5f355d98dc918d5d90f981
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4767479
Reviewed-by: Ehimare Okoyomon <eokoyomon@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Zaina Al-Mashni <zalmashni@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1182505}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4778425
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Auto-Submit: Zaina Al-Mashni <zalmashni@google.com>
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/branch-heads/5938@{chromium#126}
Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
aarongable pushed a commit that referenced this pull request Mar 22, 2024
Automatic update from google3
036ef9e 
Automatic update for 2024-03-22 UTC

Change-Id: Icd5548072f50f93cff9bc4f07e6b8e7f9c9fb82a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5386087
Bot-Commit: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com>
Commit-Queue: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com>
Cr-Commit-Position: refs/branch-heads/6367@{#126}
Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable pushed a commit that referenced this pull request Apr 19, 2024
Roll Chrome Linux PGO Profile
82f83d6 
Roll Chrome Linux PGO profile from chrome-linux-6422-1713500652-33e886ddd29e64771b557d245c69e1087d476c9d-08f3d170e450bede82a948baa72d698fbbbeecd6.profdata to chrome-linux-6422-1713527944-fc0df64156dc6e2ad2e363b805e37a3cad8692e3-9c7e4ae58cb5973ffc0dfe92e44e76bfb79aa8d8.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m125.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ia796529d0c4e905bcfdff080d528b1d86a979a39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5466954
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6422@{#126}
Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
aarongable pushed a commit that referenced this pull request May 17, 2024
[M126][Uno-D][Metrics] Create SigninMetricsService for metrics recording
111dd8d 
Implemented as a KeyedService that depends on the IdentityManager
and contains a pref service to write/read prefs. Listens to the
IdentityManager sign in events to record metrics.

Considered implementations:
1) Keyed Service (manages it's own scope).
2) Member of the IdentityManager, most events are directly emitted from
the IdentityManager itself.
3) Some existing service that already listens to the IdentityManager
such as (AccountInvestigator or GAIAInfoUpdateService).

Deciding to go with option (1) because of the following:
- The metrics that will be recorded are not very trivial and will need
read/write from prefs while listening to events from the IdentityManager
so mixing up with existing (potentially already non trivial) code is
not great.
- Solution (2) could be good, however it would require to either trigger
specific calls to the structure next to the observers, so we could just
use the observer itself. Also it would be better not to mix between
the logic and the metrics.
- Solution (2) could also be implemented as a member + observer of
IdentityManager, in that case the IdentityManager would only be a
holder for the structure, for which it was cleaner to have a
dedicated KeyedService with a proper dependency. Also it would be
simpler for direct access if needed.

(cherry picked from commit 33f7ed1)

Bug: b:333072229
Change-Id: I10835065a842f32227618ec2429c00e69d9db347
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5542075
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Ryan Sultanem <rsult@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1301388}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5545182
Auto-Submit: Ryan Sultanem <rsult@google.com>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/branch-heads/6478@{#126}
Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
0 participants