[Cors] Removed some indenting, changed title #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanRoycroft
pushed a commit
to bbc/chromium
that referenced
this pull request
Nov 2, 2020
(cherry picked from commit f3f6074) Bug: 1109322 Change-Id: I73d3143fdf37e84a953da464b561f15c4ee11827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368427 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by: Owen Min <zmin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#800600} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374510 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Yann Dago <ydago@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/branch-heads/4240@{chromium#64} Cr-Branched-From: f297677-refs/heads/master@{#800218}
ISSuh
pushed a commit
to ISSuh/chromium
that referenced
this pull request
Nov 16, 2020
This histogram will help us track how long it takes to load perfs as we add more persisted prefs. (cherry picked from commit 3ee13bf) Test: manually verify histogram value is set Bug: 1031691 Change-Id: I7b96a4ec356476132df734e8c0bf825327eafa72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956079 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by: Changwan Ryu <changwan@chromium.org> Reviewed-by: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#723130} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962021 Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/branch-heads/3987@{chromium#64} Cr-Branched-From: c4e8da9-refs/heads/master@{#722274}
hummer-studio
pushed a commit
to FydeOS-ArcHero/anbox_chromium
that referenced
this pull request
Nov 20, 2020
(cherry picked from commit 218f546) Fixed: 1067461 Change-Id: I5b9709f24bde696fb43be85d7a82b166132d0e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134232 Reviewed-by: Jia Meng <jiameng@chromium.org> Reviewed-by: Tony Yeoman <tby@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#756585} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144955 Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/branch-heads/4103@{chromium#64} Cr-Branched-From: 8ad47e8-refs/heads/master@{#756066}
billti
pushed a commit
to billti/chromium
that referenced
this pull request
Dec 22, 2020
For both IsInRemoveFirstRunPromptGroup() and IsInFirstRunModalGroup() experiment groups the native location prompt should not show after First Run finishes. The prompt will show after the user taps the action button in the modal. TBR=rohitrao@chromium.org (cherry picked from commit 2aed548) Bug: 1146456 Change-Id: I65dad9dcd3e46e45d783df79e1f3fe9aa5d2ea52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537922 Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#827422} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544020 Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/branch-heads/4324@{chromium#64} Cr-Branched-From: c73b5a6-refs/heads/master@{#827102}
patricia-gallardo
pushed a commit
to turtlebrowser/chromium
that referenced
this pull request
Dec 25, 2020
see https://docs.google.com/presentation/d/1FWFaZ_t9lYT-VB7OFwDbMqHkPJebcCAuB5Um1zBCJEg/edit?ts=5e54a041#slide=id.g853c006a44_0_0 (cherry picked from commit 64ff009) Bug: 1082616 Change-Id: I8fff7a28e0da428e7338ea44da2f52ba399ac3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203037 Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Original-Commit-Position: refs/heads/master@{#769161} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208574 Reviewed-by: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/branch-heads/4147@{chromium#64} Cr-Branched-From: 1630782-refs/heads/master@{#768962}
5455945
pushed a commit
to 5455945/chromium
that referenced
this pull request
Mar 2, 2021
This CL implements the unittest for reodering desks by drag & drop. This CL adds three helper functions: - LongTapOnDeskPreview - StartDragDeskPreview - DragDeskPreviewTo - DropDeskPreview The CL adds two unittests: DesksBentoTest.ReorderDesksByMouse and DesksBentoTest.ReorderDesksByGesture which test - Trigger drag & drop and reorder desks by mouse. - Trigger drag & drop and reprder desks by gesture. (cherry picked from commit b2bfbb1) Change-Id: I295e393ef4fdcf94a242ba4ecb011bb8f44515d3 Bug: 1154038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609587 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#843902} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640681 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/branch-heads/4389@{chromium#64} Cr-Branched-From: 9251c5d-refs/heads/master@{#843830}
pull bot
referenced
this pull request
in luojiguicai/chromium
Mar 15, 2021
On architectures such as ARM, compare_and_exchange_strong() generates a loop to retry in case of spurious failures. Since SpinningMutex::Try() is called in a retry loop anyway, there is no point having two nested loops, so use the weak form. See below the assembly before this patch, on ARM (32, thumb): 108: 6823 ldr r3, [r4, #0] 10a: b94b cbnz r3, 120 <base::PartitionRoot<true>::AllocFlagsNoHooks(int, unsigned int)+0x120> // RETRY LOOP START 10c: e854 3f00 ldrex r3, [r4] 110: b923 cbnz r3, 11c <base::PartitionRoot<true>::AllocFlagsNoHooks(int, unsigned int)+0x11c> 112: e844 0300 strex r3, r0, [r4] 116: 2b00 cmp r3, #0 118: d1f8 bne.n 10c <base::PartitionRoot<true>::AllocFlagsNoHooks(int, unsigned int)+0x10c> // RETRY LOOP END 11a: e099 b.n 250 <base::PartitionRoot<true>::AllocFlagsNoHooks(int, unsigned int)+0x250> 11c: f3bf 8f2f clrex 120: 2a01 cmp r2, #1 122: 4613 mov r3, r2 124: db03 blt.n 12e <base::PartitionRoot<true>::AllocFlagsNoHooks(int, unsigned int)+0x12e> 126: 3b01 subs r3, #1 128: bf10 yield 12a: d1fc bne.n 126 <base::PartitionRoot<true>::AllocFlagsNoHooks(int, unsigned int)+0x126> 12c: 4411 add r1, r2 12e: 0053 lsls r3, r2, #1 130: 2b40 cmp r3, #64 ; 0x40 132: f04f 0340 mov.w r3, #64 ; 0x40 136: bfb8 it lt 138: 0053 lsllt r3, r2, #1 13a: f5b1 7f7a cmp.w r1, #1000 ; 0x3e8 13e: 461a mov r2, r3 140: dbe2 blt.n 108 <base::PartitionRoot<true>::AllocFlagsNoHooks(int, unsigned int)+0x108> And after: 10a: 0053 lsls r3, r2, #1 10c: 2b40 cmp r3, #64 ; 0x40 10e: f04f 0340 mov.w r3, #64 ; 0x40 112: bfb8 it lt 114: 0053 lsllt r3, r2, #1 116: f5b1 7f7a cmp.w r1, #1000 ; 0x3e8 11a: 461a mov r2, r3 11c: f280 8087 bge.w 22e <base::PartitionRoot<true>::AllocFlagsNoHooks(int, unsigned int)+0x22e> 120: 6823 ldr r3, [r4, #0] 122: b953 cbnz r3, 13a <base::PartitionRoot<true>::AllocFlagsNoHooks(int, unsigned int)+0x13a> // NO RETRY LOOP 124: e854 3f00 ldrex r3, [r4] 128: b113 cbz r3, 130 <base::PartitionRoot<true>::AllocFlagsNoHooks(int, unsigned int)+0x130> 12a: f3bf 8f2f clrex 12e: e004 b.n 13a <base::PartitionRoot<true>::AllocFlagsNoHooks(int, unsigned int)+0x13a> 130: e844 0300 strex r3, r0, [r4] // NO RETRY LOOP 134: 2b00 cmp r3, #0 136: f000 80a5 beq.w 284 <base::PartitionRoot<true>::AllocFlagsNoHooks(int, unsigned int)+0x284> 13a: 2a01 cmp r2, #1 13c: 4613 mov r3, r2 13e: dbe4 blt.n 10a <base::PartitionRoot<true>::AllocFlagsNoHooks(int, unsigned int)+0x10a> 140: 3b01 subs r3, #1 142: bf10 yield 144: d1fc bne.n 140 <base::PartitionRoot<true>::AllocFlagsNoHooks(int, unsigned int)+0x140> 146: 4411 add r1, r2 148: e7df b.n 10a <base::PartitionRoot<true>::AllocFlagsNoHooks(int, unsigned int)+0x10a> Bug: 998048 Change-Id: I3ae4ec3f0e332e68093c34a2e5ea1f98824cf646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2760320 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#862809}
ls60629
pushed a commit
to ls60629/chromium
that referenced
this pull request
Apr 11, 2021
This reverts commit 06c77b6. Reason for revert: Feature no longer needed. Original change's description: > Add feature to control DexFixer > > This will allow us to experiment with DexFixer on/off. The flag defaults > to disabled since once DexFixer runs, you can't undo it without > updating. > > Bug: 1152970 > Change-Id: Icaf57defa1b0aaf9daff03fb23cc44ef5c11a2bb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2698755 > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#854899} TBR=agrieve@chromium.org (cherry picked from commit d721f29) Bug: 1152970 Change-Id: I04ea0555c6d675bbcccc93b199023e8f06a05792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2729477 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#859038} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2729539 Reviewed-by: Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/4430@{chromium#64} Cr-Branched-From: e5ce7dc-refs/heads/master@{#857950}
GrumpyOldTroll
pushed a commit
to GrumpyOldTroll/chromium
that referenced
this pull request
Apr 13, 2021
This CL implements the unittest for reodering desks by drag & drop. This CL adds three helper functions: - LongTapOnDeskPreview - StartDragDeskPreview - DragDeskPreviewTo - DropDeskPreview The CL adds two unittests: DesksBentoTest.ReorderDesksByMouse and DesksBentoTest.ReorderDesksByGesture which test - Trigger drag & drop and reorder desks by mouse. - Trigger drag & drop and reprder desks by gesture. (cherry picked from commit b2bfbb1) Change-Id: I295e393ef4fdcf94a242ba4ecb011bb8f44515d3 Bug: 1154038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609587 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#843902} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640681 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/branch-heads/4389@{chromium#64} Cr-Branched-From: 9251c5d-refs/heads/master@{#843830}
blattersturm
pushed a commit
to citizenfx/chromium
that referenced
this pull request
Apr 29, 2021
Add 'Activate' button to network-list-items containing an item that is a pSIM network that is unactivated with a valid payment url. Screenshot: https://screenshot.googleplex.com/7QWY3cHSuZbwzHz.png (cherry picked from commit e5fc96d) Bug: 1196507 Change-Id: Iecd4a6c623bef2826142b07ff38b5972886fdbe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2816200 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#871190} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2826670 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Gordon Seto <gordonseto@google.com> Cr-Commit-Position: refs/branch-heads/4472@{chromium#64} Cr-Branched-From: 3d60439-refs/heads/master@{#870763}
pull bot
referenced
this pull request
in jamlee-t/chromium
Jun 2, 2021
Updates text-fragments-polyfill to latest main: * Undo the early return in getSearchSpaceForStart (#68) * Fix overrideMap generation logic (#65) * searchSpace: add return if trimmed search space is empty (#64) * Fix branches * Change branches * Release v3.3.0 * Fix race condition during initialization (#62) * Add fragment generation to dist * New release Bug: 1215287 Change-Id: I79f9ba5968b51f2812f07d4c66af7e3b734fd3f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2928825 Reviewed-by: sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#888159}
GrumpyOldTroll
pushed a commit
to GrumpyOldTroll/chromium
that referenced
this pull request
Jul 23, 2021
Before this CL, when previous path is undefined a console error is shown, this CL fixes this issues and makes sure only defined oldPaths are passes to RouteOriginBehaviorImpl.currentRouteChanged. (cherry picked from commit 29b2695) Fixed: 1213162 Change-Id: I819a3de2acdadab9ea44ea2fd84d6d28cf93868a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2917715 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#886567} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2918477 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4515@{chromium#64} Cr-Branched-From: 488fc70-refs/heads/master@{#885287}
GrumpyOldTroll
pushed a commit
to GrumpyOldTroll/chromium
that referenced
this pull request
Jul 23, 2021
Updates text-fragments-polyfill to latest main: * Undo the early return in getSearchSpaceForStart (chromium#68) * Fix overrideMap generation logic (chromium#65) * searchSpace: add return if trimmed search space is empty (chromium#64) * Fix branches * Change branches * Release v3.3.0 * Fix race condition during initialization (chromium#62) * Add fragment generation to dist * New release (cherry picked from commit 45e39bb) Bug: 1215287 Change-Id: I79f9ba5968b51f2812f07d4c66af7e3b734fd3f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2928825 Reviewed-by: sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#888159} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2933881 Auto-Submit: Guillaume Jenkins <gujen@google.com> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/branch-heads/4515@{#257} Cr-Branched-From: 488fc70-refs/heads/master@{#885287}
GrumpyOldTroll
pushed a commit
to GrumpyOldTroll/chromium
that referenced
this pull request
Sep 4, 2021
The experiment results show slightly increased memory usage from the discoverability icon: https://crbug.com/1228739#c1 This CL removes some unnecessary allocations. The static getHighestPriorityPermission() method in SingleWebsiteSettings triggers lots of classes to be loaded. To avoid this, it is moved to a separate util class. ContentSettingsResources has some static configuration data. Replace it with a switch statement to avoid permanently allocating memory for this. (cherry picked from commit 48b6f8d) Bug: 1228739 Change-Id: I3d36dc63d41fc8d896a2710ece58e557a5318759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3026865 Reviewed-by: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by: Tomasz Wiszkowski <ender@google.com> Auto-Submit: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Original-Commit-Position: refs/heads/master@{#902441} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3039745 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/branch-heads/4577@{chromium#64} Cr-Branched-From: 761ddde-refs/heads/master@{#902210}
nift4
pushed a commit
to nift4/chromium
that referenced
this pull request
Sep 22, 2021
(cherry picked from commit 16e7c57) Fixed: 1236496 Change-Id: Icb69e746bc365c0331179d58e562633f3e790237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3098367 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#912638} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3100532 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/branch-heads/4606@{chromium#64} Cr-Branched-From: 35b0d5a-refs/heads/master@{#911515}
GrumpyOldTroll
pushed a commit
to GrumpyOldTroll/chromium
that referenced
this pull request
Oct 21, 2021
If AuthenticationFlow is call for sign-in only, the 2 following dialogs should skipped: * merge/wipe data dialog * managed account confirmation dialog This patch updates SyncScreenCoordinator and UserSigninCoordinator to use: * POST_SIGNIN_ACTION_NONE to open the advanced settings * POST_SIGNIN_ACTION_START_SIGN to do the final sign-in (cherry picked from commit 30a5304) Fixed: 1247230 Bug: 1245577 Change-Id: Ie0d598841094bc19c10f580989c76818722c04d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3145217 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Nohemi Fernandez <fernandex@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#920687} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3160214 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/branch-heads/4638@{chromium#64} Cr-Branched-From: 159257c-refs/heads/main@{#920003}
FolMing
pushed a commit
to Decentr-net/chromium
that referenced
this pull request
Nov 11, 2021
Only skip the animatePanelToState for the in bar Related Searches animation. The previous fix https://crrev.com/c/3211433 skip in too many conditions, this fix only skip in one condition. (cherry picked from commit 8b9a255) Bug: 1258274 Change-Id: If1bb7157fe4898acc0fb0303bf9c3785b4ad7df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3215371 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by: Donn Denman <donnd@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#930274} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3219632 Auto-Submit: Gang Wu <gangwu@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4664@{chromium#64} Cr-Branched-From: 24dc4ee-refs/heads/main@{#929512}
davidwongiiss1984
pushed a commit
to omsproject/chromium
that referenced
this pull request
Dec 14, 2021
Change-Id: Ia1afb6b52cc36027abf57c043c022a0bb70185a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3270638 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4692@{chromium#64} Cr-Branched-From: 038cd96-refs/heads/main@{#938553}
blueboxd
referenced
this pull request
in blueboxd/chromium-legacy
Feb 3, 2022
This is a speculative fix for the crash mentioned in the bug. This added a nullptr check for a variable inside the function. (cherry picked from commit cc8901b) Bug: 1279412 Change-Id: I5d67d9c7a5122c78f46fe80c7e5199fcb75a46ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339105 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#951719} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337987 Cr-Commit-Position: refs/branch-heads/4758@{#64} Cr-Branched-From: 4a2cf4b-refs/heads/main@{#950365}
GrumpyOldTroll
pushed a commit
to GrumpyOldTroll/chromium
that referenced
this pull request
Mar 3, 2022
When switching back and forth between lines using tap triggering the panel does not hide and show again. In this case the thumbnails are not always reloaded appropritately. This is due to a regression introduced in https://crrev.com/c/3316740. Instead of the percentage we were using 1.0-percentage but not changing the early exit compares when using that value. BUG=1288917 (cherry picked from commit 6eb09d4) Change-Id: I8062403bda59154fd4526b9e60d16ad3cf4048e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3405432 Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by: Gang Wu <gangwu@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#963084} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3418257 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4844@{chromium#64} Cr-Branched-From: 007241c-refs/heads/main@{#961656}
darinwf
pushed a commit
to neevaco/chromium
that referenced
this pull request
Apr 19, 2022
(cherry picked from commit c1f8ca5) Fixed: chromium:1298149 Change-Id: Ib6d7efc99d1d21172a12d11231f8a6f3ba6243af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3472847 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#972942} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3477079 Auto-Submit: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/branch-heads/4896@{chromium#64} Cr-Branched-From: 1f63ff4-refs/heads/main@{#972766}
fujunwei
pushed a commit
to fujunwei/chromium
that referenced
this pull request
Apr 22, 2022
Change-Id: I68f7d32e4da3d38ec5eff74ebb8e518c35b11b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3598031 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5005@{chromium#64} Cr-Branched-From: 5b4d945-refs/heads/main@{#992738}
pkviet
pushed a commit
to pkviet/chromium
that referenced
this pull request
Jun 4, 2022
Icon load requests may cause item metadata updates (if the icon is already ready, it may get updated synchronously). Given that metadata updates may potentially change item position in model, initiate icon load only after the item was added to apps grid view model (item moves update apps grid view model assuming items in the view model are in sync with item indices in the app list model). BUG=1307902 (cherry picked from commit 8d80d5f) Change-Id: I71a7b837a0967a6fcd0d4e7e9d491da237ebda07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3537880 Reviewed-by: Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#982982} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3543792 Reviewed-by: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/branch-heads/4951@{chromium#64} Cr-Branched-From: 27de622-refs/heads/main@{#982481}
pkviet
pushed a commit
to pkviet/chromium
that referenced
this pull request
Jun 6, 2022
…rl_for_deduping In a previous patch, we made SimilarVisitDeduperClusterFinalizer use url_for_display instead of url_for_deduping: https://chromium-review.googlesource.com/c/chromium/src/+/3646808 That was not the way to go. Instead, this CL restores the usage of url_for_deduping, as well as increases the aggression of url_for_deduping to ALSO strip way the URL query, so that URLs that differ only by the query part may also be deduped by SimilarVisitDeduperClusterFinalizer, assuming that the page title differs. I added more commentary too, to explain that so long as url_for_deduping is strictly more aggressive than url_for_display, we should not display any identical rows in the UI. (cherry picked from commit d60f7bf) Bug: 1325154 Change-Id: I105f9e74e98924deddf3c2481517962cd12a6b15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3645237 Reviewed-by: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1003896} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3652251 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Tommy Li <tommycli@chromium.org> Auto-Submit: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/branch-heads/5060@{chromium#64} Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
darinwf
pushed a commit
to neevaco/chromium
that referenced
this pull request
Aug 10, 2022
Fixes crbug.com/1336144. Tested manually. Merge approved in crbug.com/1336144. (cherry picked from commit 046c162) Bug: 1336144, 1286276 Change-Id: I44cb479f12accaa140aecd783c2306f243aaaf2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3702343 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1013919} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3707792 Cr-Commit-Position: refs/branch-heads/5112@{chromium#64} Cr-Branched-From: b13d3fe-refs/heads/main@{#1012729}
beasonxu
pushed a commit
to ipxbro/chromium
that referenced
this pull request
Sep 3, 2022
Perhaps we can claim to have less memory available than in `active_file`? (cherry picked from commit dfe161c) Bug: 1346531 Change-Id: Ice92d6aae9586d5a1eaddfede60ce0fae97e7919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3783406 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1028231} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3789485 Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/branch-heads/5195@{chromium#64} Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
MaoHan001
pushed a commit
to riscv-android-src/chromium
that referenced
this pull request
Jan 17, 2023
This CL updates the ash version ['110.0.5421.0'] for Lacros version skew testing. This cl only affect linux-lacros config builders like linux-lacros-tester-rel, linux-lacros-rel. This cl will certainly NOT affect Lacros on-device builders(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab, etc) or any other platforms. If this CL caused regressions, please revert and stop the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org, yjt@google.com. R=rubber-stamper@appspot.gserviceaccount.com Bug: None Change-Id: I57b7ede04fe45c5543e43f50eb2f09ca1e758a0a Requires-Testing: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4024657 Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5414@{chromium#64} Cr-Branched-From: 4417ee5-refs/heads/main@{#1070088}
wwwppp0801
pushed a commit
to wwwppp0801/chromium
that referenced
this pull request
Feb 13, 2023
This CL records a metric when the user opens a Tab from a context menu. (cherry picked from commit dd9670e) Bug: 1401691 Change-Id: I2fb8290b838dd742b1938ea6d48255a1b58da416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4100907 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Weilun Shi <sweilun@chromium.org> Auto-Submit: Ewann Pellé <ewannpv@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1084391} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4117080 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/5481@{chromium#64} Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
chirayudesai
pushed a commit
to chirayudesai/chromium
that referenced
this pull request
Mar 7, 2023
gpu::ToDawnFormat returns wgpu::TextureFormat::Undefined for several common formats. When wrapped in a GrBackendFormat, Skia assumes that the format is valid and passes it back to Dawn CreateTexture. When Dawn validation is disabled in release builds this can cause security issues. (cherry picked from commit b9c050d) Bug: 1350740 Change-Id: I00b6fd3145c46a8f412e45fcb461f6fad083c8a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4200081 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Saifuddin Hitawala <hitawala@chromium.org> Reviewed-by: Saifuddin Hitawala <hitawala@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1098595} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4210828 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5563@{chromium#64} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
calyxos-gerrit
pushed a commit
to CalyxOS/chromium
that referenced
this pull request
Mar 31, 2023
This CL cleans up the navigation state by properly popping the correct view controller and cleaning up after the navigation did show vc (cherry picked from commit a08ef9c) Bug: 1418787 Change-Id: Ife96eb4976f430001334da17f84c67534147be02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4289305 Reviewed-by: Robbie Gibson <rkgibson@google.com> Commit-Queue: Cheick Cisse <cheickcisse@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1109929} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4295058 Auto-Submit: Cheick Cisse <cheickcisse@google.com> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/branch-heads/5615@{chromium#64} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
l0hn
pushed a commit
to l0hn/chromium_test
that referenced
this pull request
Jun 9, 2023
Current: https://screenshot.googleplex.com/AWbHKjTTfSh7QEu Expect: https://screenshot.googleplex.com/9ALj2QUrRrMAVEN (cherry picked from commit 85a185b) Bug: 1440551 Change-Id: I8f8ce2d69455b037f90847caf46c6db1837fb910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4482815 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1136621} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4490846 Auto-Submit: Tina Wang <tinazwang@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/branch-heads/5735@{chromium#64} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
msizanoen1
pushed a commit
to qtmlabs/chromium
that referenced
this pull request
Jun 25, 2023
Change-Id: I0f5b8a6fa2a9b6941e36815403d67f9d9b6aeb3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4641215 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5845@{chromium#64} Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
aetota61
pushed a commit
to monkbrowser/monk-browser
that referenced
this pull request
Aug 2, 2023
(cherry picked from commit 249ef2a) Bug: 1448451 Change-Id: Ied2207b427e642d67b97ba4af99c6b2dc88a652c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4562741 Auto-Submit: Emily Shack <emshack@chromium.org> Commit-Queue: Emily Shack <emshack@chromium.org> Reviewed-by: John Lee <johntlee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1148599} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4568041 Cr-Commit-Position: refs/branch-heads/5790@{chromium#64} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
trflynn89
pushed a commit
to RebelBrowser/rebel
that referenced
this pull request
Oct 26, 2023
`wdspec` subtests can apparently have the `ERROR` status (e.g., WebDriver connection closed abnormally [0]), which can incorrectly block valid metadata. Fix `lint-wpt` so that valid statuses are derived from the upstream's single source of truth, which should prevent future inconsistencies (e.g., crbug.com/1446034). [0]: https://luci-milo.appspot.com/ui/inv/build-8770763876869478481/test-results?q=external%2Fwpt%2Fwebdriver%2Ftests%2Fclassic%2Fperform_actions%2Fpointer_touch.py&sortby=&groupby= (cherry picked from commit fb61748) Bug: 1478884 Change-Id: I4bd71edd09862f44a5b306e84177801153e85f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4844713 Auto-Submit: Jonathan Lee <jonathanjlee@google.com> Commit-Queue: Jonathan Lee <jonathanjlee@google.com> Commit-Queue: Weizhong Xia <weizhong@google.com> Reviewed-by: Weizhong Xia <weizhong@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1192741} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4852560 Cr-Commit-Position: refs/branch-heads/5993@{chromium#64} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
vuzix-jeff
pushed a commit
to Vuzix/chromium
that referenced
this pull request
Nov 3, 2023
Because I'm a dufus, I let the flag expire. This is likely to be enabled by default in 118, so _maybe_ this won't matter, but let's buy ourselves a little bit of time. (cherry picked from commit 2b00437) Bug: 1479665 Change-Id: I719d0f63704487f9433a6cde9affae670c55a341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4913416 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1205408} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4915470 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Prudhvikumar Bommana <pbommana@google.com> Cr-Commit-Position: refs/branch-heads/6045@{chromium#64} Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
consp1racy
pushed a commit
to signageos/chromium-chromium
that referenced
this pull request
Nov 25, 2023
Need this to ensure the quick settings widget is always activated when focus is transferred from the message center widget. (cherry picked from commit 8126ced) Bug: 1048127 Change-Id: I6d142ea37bf270712d609024a0d0e09bd5a5d295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036274 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Tim Song <tengs@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#738359} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039975 Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/branch-heads/4044@{chromium#64} Cr-Branched-From: a6d9daf-refs/heads/master@{#737173}
Aikoyori
referenced
this pull request
in Pissandshittium/pissandshittium
Dec 8, 2023
Roll Chrome Mac PGO profile from chrome-mac-6099-1698835485-1ca4f5aab340ca8e834cdf5f4d7d7013513cce51.profdata to chrome-mac-6099-1698860990-0b36c76d0b89694ae3e1dc09bb76f0005bf0c009.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m120.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1edfb96192f7584f8300d913771e3579ec726591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4997593 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6099@{#64} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable
pushed a commit
that referenced
this pull request
Jan 6, 2024
Roll Chrome Win32 PGO profile from chrome-win32-6167-1701905253-8d8b1642f6ab4c952ad72ed39395a34d714be291.profdata to chrome-win32-6167-1701921900-c72d610b4e9b84002afc730cdef62700b57363b6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m121.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9fe4dfd45620d8741f3cae7cc648d77f61b21710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5098528 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6167@{#64} Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable
pushed a commit
that referenced
this pull request
Jan 25, 2024
Before this change we assumed that finishing an external request and getting content::ServiceWorkerExternalRequestResult::kNullContext during browser ack of a service worker event was impossible. But crrev.com/c/5202906 shows that this is possible. EventRouter, EventAckData, and BrowserContext can outlive the ServiceWorkerContextCore of the worker (which when null causes kNullContext). Unfortunately this is very difficult to test due to raciness, but I am looking into ways to do this so that we can prevent regressions in the future. Due to this being a current beta release blocker it seems okay to defer that to a later time. (cherry picked from commit 743a726) Bug: 1520186 Change-Id: I5d4fad69d569603ee4fb492c12fe7af209663dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5230308 Commit-Queue: David Bertoni <dbertoni@chromium.org> Auto-Submit: Justin Lulejian <jlulejian@chromium.org> Commit-Queue: Justin Lulejian <jlulejian@chromium.org> Reviewed-by: David Bertoni <dbertoni@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1251150} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5234962 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#64} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
aarongable
pushed a commit
that referenced
this pull request
Feb 22, 2024
Commits rolled: https://chromium.googlesource.com/v8/v8.git/+log/006cf0cc2b36..131f94e93092 Generated by: go/bbid/8755359428708659889 Change-Id: I68abb10bcd941d08fe0142ed85e48b4ca58195d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5319571 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6312@{#64} Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
aarongable
pushed a commit
that referenced
this pull request
Mar 21, 2024
…d profiles (cherry picked from commit e4cef60) Bug: 326041000 Change-Id: I0d116c8d365a68fcb0c27594959e808f13a525a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5321460 Reviewed-by: Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: James Lee <ljjlee@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1274939} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5378638 Auto-Submit: James Lee <ljjlee@google.com> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/branch-heads/6367@{#64} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
NaaeemMalik
pushed a commit
to SoftwarePrince/Egon-Chromium
that referenced
this pull request
Mar 22, 2024
- Add sync batch model execution API. - Add a dedicated background thread for model file loading. - Update the existing async model execution to load model on the background thread if not loaded, and execute model on the model execution thread. - Enable sync url suggestion scoring in autocomplete controller. (cherry picked from commit c1e7dd1) Bug: 1468407, b/294133650 Change-Id: I61fa3711411cf9a9e59f88a01ff03ed27747dc81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4726969 Commit-Queue: Jun Zou <junzou@google.com> Reviewed-by: manuk hovanesian <manukh@chromium.org> Reviewed-by: Angela Yoeurng <yoangela@chromium.org> Reviewed-by: Robert Ogden <robertogden@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1181841} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4775305 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Jun Zou <junzou@chromium.org> Cr-Commit-Position: refs/branch-heads/5938@{chromium#64} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
jiongle1
referenced
this pull request
in jiongle1/chromium
Mar 27, 2024
This change improves the metrics for IPP Printer queries. The result is broken up in to two separate boolean enums: - Printing.CUPS.IppAttributesQueryResult captures whether we were able to successfully query the printer. - Printing.CUPS.IppAttributesSuccess captures whether the request for attributes was successful, given that we were able to reach the printer (cherry picked from commit bdfdac8) Bug: 1012437 Change-Id: If11ae1b03c3f2f76618d91eef8f49f1aefdb75d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864022 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Sean Kau <skau@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#707234} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874268 Reviewed-by: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/branch-heads/3945@{#64} Cr-Branched-From: e4635ff-refs/heads/master@{#706915}
aarongable
pushed a commit
that referenced
this pull request
Apr 18, 2024
(cherry picked from commit 54f7b62) Fixed: 335135200, 335135199, 334873242, 334872099 Change-Id: I58ed82968be04a3bdcd0fcc2f823004860258832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5455378 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Aliona Dangla <alionadangla@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1287974} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5462601 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Aliona Dangla <alionadangla@chromium.org> Cr-Commit-Position: refs/branch-heads/6422@{#64} Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
aarongable
pushed a commit
that referenced
this pull request
May 16, 2024
This CL updates the ash version ['126.0.6477.0', '124.0.6367.219'] for Lacros version skew testing. This cl only affect linux-lacros config builders like linux-lacros-tester-rel, linux-lacros-rel. This cl will certainly NOT affect Lacros on-device builders (lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab, etc) or any other platforms. If this CL caused regressions, please revert and stop the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller Also please file a bug to OS>LaCrOS>Partner, and CC kuanhuang@chromium.org. R=rubber-stamper@appspot.gserviceaccount.com Bug: None Change-Id: I7b24a5c60f565cc8cc9e8a47db9b5d2edba08832 Requires-Testing: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5540378 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#64} Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}
aarongable
pushed a commit
that referenced
this pull request
Jun 14, 2024
Change-Id: I2440ed2cd2b3855dd599aa74f28e60f8dcd0b6ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5626154 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6533@{#64} Cr-Branched-From: 7e0b87e-refs/heads/main@{#1313161}
aarongable
pushed a commit
that referenced
this pull request
Jul 26, 2024
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-6613-1721858111-3e845ae7117c646d4c95d9f993b7e20dee386494-5908cc6966834c8e0a9c4c0378f21a5c89326e66.profdata to chrome-mac-arm-6613-1721863940-f0a604e402eba786e468579030707d347b777183-1fe70e084312215428868b8a922ed29385fc8ce6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I65c4238ea4de8a8019180d4b1fd42bdd0792c9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5739352 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6613@{#64} Cr-Branched-From: 03c1799-refs/heads/main@{#1331488}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed title to make it a bit more friendly from 'running' to 'running...'.
The Doctype is usually uppercase with lowercase html. Changed that from '<!doctype html>' to ''.
Some indenting on the bottom was not required. This also lowers the file size by just a few bytes.
Thanks!