forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from chromium:main #62
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This is an automated release commit. * Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true Change-Id: I4582a05b02ade3ad0a58a8ffc7214eb47b85847f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3293931 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#943946}
Move operations that are same-filesystem do not require disk space. Disable disk space checks for same-filesystem moves. Context: The browser, or more specifically Chrome Storage, has the concept of mount points (implemented as ExternalMountPoints). a filesystem_id can be parsed from an entry's FileSystemURL, which uniquely identifies the mount point on which the entry resides. Files app has the concept of volumes. By design, Files app can have multiple volumes registered under the same ExternalMountPoints instance. For example removable devices are all mapped to their own volumes, and these volumes all map to the same ExternalMountPoints instance, with the "/media/removable" mount path. However, a single volume can't map to multiple ExternalMountPoints instances. To determine whether a move is same-filesystem: - We first check whether the source and the destination are on the same volume, or across My files and Downloads: This is handled by IsCrossFileSystem. - If it returns false, we compare the source and destination's filesystem_id (concept of mount point). This handles the case where no volume is found for a given entry. Bug: 204838286 Change-Id: I4412ebd262895d3dd40e709cf0ba20f572ab4f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3288609 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/main@{#943947}
This patch is ported from WebKit. It reduces some overhead of HTMLDocumentParser for innerHTML, which claims that it has ~ 0.5% progression for Speedometer. After ported into blink, we also observe about 0.5% performance improvement on Speedometer2. WebKit changeset@272622 Url: http://trac.webkit.org/changeset/272622/ Author: Ryosuka Niwa <rniwa@webkit.org> Date: Tue Feb 9 4:38:15 2021 Change-Id: Icc2e4b61154786a740a62a3a96837553acc38980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3280084 Reviewed-by: Mason Freed <masonf@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#943948}
This CL ensures we handle the case where a prediction suggestion is given that partially matches the current preceding text. Confirmed length for a prediction suggestion should be zero on initial showing. Case: preceding text -> "this ", suggests -> "is what we" In ths case above the confirmed length should be zero. Prior to this CL the suggester would match the characters "is " as confirmed. Bug: 1146266 Change-Id: I424d9fb4f14a64c31506d4f7e7644fb3a679381e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3291212 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org> Cr-Commit-Position: refs/heads/main@{#943949}
OnExtensionLoaded is not called for disabled extensions/Chrome apps. So Chrome app publisher can't load all Chrome apps, including the disabled extensions, during the system startup phase. Add a post function OnExtensionsReady, and when extensions are ready, call Chrome app publisher to load all Chrome apps/extensions during the system startup phase. BUG=1271332 Change-Id: I636d15c1a0745cb5ee8e6ced4d872d566bf51dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3288822 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#943950}
https://crrev.com/c/1290581: - IDS_FILE_BROWSER_SHARE_BEFORE_OPEN_CROSTINI_MULTIPLE - IDS_FILE_BROWSER_SHARE_BEFORE_OPEN_CROSTINI_SINGLE - IDS_FILE_BROWSER_SHARE_BEFORE_OPEN_CROSTINI_TITLE https://crrev.com/c/1909052: - IDS_PLUGIN_VM_INSTALLER_ERROR_MESSAGE https://crrev.com/c/2068871 - message id was renamed but the sha1 file wasn't. Given the string is a bit different now, just deleting the sha1. - IDS_PLUGIN_VM_INSTALLER_FINISHED_MESSAGE https://crrev.com/c/1475686: - IDS_CROSTINI_EXPORT_NOTIFICATION_DONE - IDS_CROSTINI_EXPORT_NOTIFICATION_FAILED - IDS_CROSTINI_EXPORT_NOTIFICATION_IN_PROGRESS - IDS_CROSTINI_EXPORT_TITLE - IDS_CROSTINI_IMPORT_NOTIFICATION_DONE - IDS_CROSTINI_IMPORT_NOTIFICATION_FAILED - IDS_CROSTINI_IMPORT_NOTIFICATION_IN_PROGRESS - IDS_CROSTINI_IMPORT_TITLE Bug: 1171575 Change-Id: Ib2fbd5400ab00ea0fea3f68aeacbdba277e5cd1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295211 Auto-Submit: Timothy Loh <timloh@chromium.org> Reviewed-by: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/main@{#943951}
These files no longer exist, so code checking RecordComputedAction() therein should be futile and unnecessary. Some files still exist but the related metrics are obsolete and no longer emitted. No further inspection has been done on the checks and handling of other metrics; they could potentially be only there because of the no-longer-existent files. __delete_it__ Bug: None Change-Id: I45e0739a83941e3847a6dd67368e599f21813cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3289569 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/main@{#943952}
Roll Chrome Win64 PGO profile from chrome-win64-main-1637538221-3b5413efea9a1c5ecbaad8ec313cc2d13b3a5ebd.profdata to chrome-win64-main-1637549711-71d911ecd19a8b788e2ab876084cccde657456c2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If0ae78782aa2b0a8f891acadc50ae719c7ac2182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3294560 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#943953}
Roll Chrome Win32 PGO profile from chrome-win32-main-1637538221-529e7ab7a862724a085b9603bca76c6bb89f35aa.profdata to chrome-win32-main-1637549711-802c7fdb95998312b1378b6e58392105d271da96.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I36b2d1995d88ff500b92d8b7e4099ea531e187c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295222 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#943954}
Currently suggestions are only dismissed if the user deletes ALL chars that make up the suggestion. For example - user types: hap - suggestion: happy birthday To dismiss the suggestion, the user then would have to delete the chars "hap". This CL fixes this behavior by immediately dismissing a suggestion once the user deletes chars "beyond" the suggestion point in the string (in the case above, as soon as the user deletes "p" the suggestion is dismissed). Bug: 1146266 Change-Id: I30c9df20c19f545688da56318dd6c6db240a7138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295117 Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/main@{#943955}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e87bd55c3f72..ce9262ec60f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC asamidoi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: asamidoi@google.com Change-Id: I77746c4a673d9c0b0a91d3407ee2c5e7017a6676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3294558 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#943956}
This CL removes a TODO for IsInPrimaryMainFrame in LogoutTabHelper and makes LogoutTabHelper listen to PrimaryPageChanged instead of DidFinishNavigation. Prerendering tests are unnecessary since the LogoutTabHelper is self-destructed when the primary page navigation finishes. Bug: 1218946 Change-Id: Icb1368366a39dd4c8ad81463bcd1aeb730c5ca10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3288466 Commit-Queue: Hyowon Kim <hyowon@igalia.com> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/main@{#943957}
Previously, blend was resolved every time a JSON file was added to the model. This doesn't work for cros_colors because cros_palette is added to the model after cros_colors, so the final RGB didn't exist for dependencies such as google_grey_900. Solution: Only resolve blend after all the JSON files have been added. Updated style_variable_generator_test to test blend as well. Also update the Validate function to validate blend references. Bug: b:205495160 Change-Id: I60d018c84c85ffb0cfd6c27e6765cef5689a595d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3292469 Commit-Queue: Zufeng Wang <zufeng@google.com> Reviewed-by: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/main@{#943958}
- Finalize the strings. - Load current screen lock state from C++. - Move the position of subtext next to the radion button. Original: https://screenshot.googleplex.com/wj6MdVrLm9nyCEA.png New: https://screenshot.googleplex.com/9eDufGSEjHmMDKY.png "OSSettingsMultideviceNotificationAccessSetupDialogV3Test.*" Bug: b/184648164 Test: ./out/Default/browser_tests --gtest_filter= Change-Id: Ie9c540a9fc423c7f0b04794cc63261866b620eca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3233958 Commit-Queue: Guanru Lee <guanrulee@chromium.org> Reviewed-by: Jon Mann <jonmann@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/main@{#943959}
Bug: 1272360 Change-Id: I8c12d7b78683ad16bb7141700d0d89bdec61e16a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3292904 Commit-Queue: Asami Doi <asamidoi@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Owners-Override: Asami Doi <asamidoi@chromium.org> Auto-Submit: Asami Doi <asamidoi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/main@{#943960}
Exclude raw pointer fields that point to Objective-C objects from the rewrite. Bug: 1272324 Change-Id: Ia08c011afcebe0eac5508c3ee61eddec831d7fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3294655 Reviewed-by: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/main@{#943961}
https://skia.googlesource.com/skia.git/+log/7ecacbc4c6be..c8821bbe2f59 2021-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 53db01bf1e64 to 4e3ddbd95589 (10 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Change-Id: Ib0b41997a52c35c2c01f54054c73fb7cb6c63a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3291788 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#943962}
….html on multi platforms Flaky dashboard: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVygwELEgVGbGFrZSJ4Y2hyb21pdW1AYmxpbmtfd2ViX3Rlc3RzQGV4dGVybmFsL3dwdC93ZWJydGMtZW5jb2RlZC10cmFuc2Zvcm0vUlRDUGVlckNvbm5lY3Rpb24taW5zZXJ0YWJsZS1zdHJlYW1zLXNpbXVsY2FzdC5odHRwcy5odG1sDA Bug: 1220114 Change-Id: I93224174b488a56e733f01293c7525e803c4d8ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3291302 Commit-Queue: Asami Doi <asamidoi@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Owners-Override: Asami Doi <asamidoi@chromium.org> Auto-Submit: Asami Doi <asamidoi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/main@{#943963}
https://google.github.io/styleguide/cppguide.html#Enumerator_Names > use kEnumName not ENUM_NAME. This CL has no behavior changes. Bug: 1270198 Change-Id: I3d6b85a608ea3ced1f559f4e2a946e852d5d8ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295107 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/main@{#943964}
…sizes-multipart.html Flaky on multiple platform: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTwsSBUZsYWtlIkRjaHJvbWl1bUBicm93c2VyX3Rlc3RzQFBERkV4dGVuc2lvblNhdmVXaXRoUG9saWN5VGVzdC5TYXZlV2l0aFBvbGljeQw Bug: 1269535 Change-Id: If27b048dac467a1c4d1f74e9266204758e5c338f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295121 Commit-Queue: Asami Doi <asamidoi@chromium.org> Owners-Override: Asami Doi <asamidoi@chromium.org> Auto-Submit: Asami Doi <asamidoi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/main@{#943965}
…ack-forward.html Flaky dashboard: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTQsSBUZsYWtlIkJjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAcGx1Z2lucy9wbHVnaW4tZG9jdW1lbnQtYmFjay1mb3J3YXJkLmh0bWwM Bug: 1272376 Change-Id: I49a08957ebefe94f1c2b4b9f68cb2501923f0394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3293547 Commit-Queue: Asami Doi <asamidoi@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Owners-Override: Asami Doi <asamidoi@chromium.org> Auto-Submit: Asami Doi <asamidoi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/main@{#943966}
https://skia.googlesource.com/skia.git/+log/c8821bbe2f59..647bd84de7cc 2021-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from b9c0194c4e1e to 647026fa49c2 (39 revisions) 2021-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from f5cf2d08ff9c to 6e23c082b73a (4 revisions) 2021-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e7ac769 to b779de5 (534 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Test: Test: Test: BuiltinVariableVertexIdTest.LineLoop/ES3_Vulkan_SwiftShader Test: Test: Test: GLSLTest_ES3.GLVertexIDIntegerTextureDrawArrays/* Test: Test: Test: GLSLTest_ES3.GLVertexIDIntegerTextureDrawArrays/ES3_Vulkan_SwiftShader Test: Test: Test: end2end, perftests, gles1_conformance Change-Id: I5214fc9e9be623667347052858eb9a3e8cb0caee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3291791 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#943967}
Add exclusions that address the compiler errors below: https://docs.google.com/document/d/13hYSTf7zCj3b9u7rs4eaOOesrsdZ5t3pwf0MNDmJiMc/edit?usp=sharing&resourcekey=0-s56sQQR5IoZXINPmNVDK_A Bug: 1272324 Change-Id: I89d3c81db6a48f75313dadacf0b54621107e8517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3294654 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/main@{#943968}
Filled in the implementation to add passpoint credentials. This patch only have support for username and password EAP-TTLS. Certificate provisioning and EAP-TLS will be added in another patch. BUG=b:195262431 TEST=Called shill manager's AddPaspointCredentials without error. Change-Id: Ibc898c11574c6f30e3dec93ef24b806524e76b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3272121 Commit-Queue: Jason Jeremy Iman <jasongustaman@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Hugo Benichi <hugobenichi@google.com> Cr-Commit-Position: refs/heads/main@{#943969}
Seems like this test was fixed as a drive-by when CSS copying was fixed. The only difference is a single newline which we straight-up rebaseline. R=tvanderlippe@chromium.org Bug: 1215072 Change-Id: I087e8db4a338f77b8c02ac03258e35b7724303d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3289255 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/main@{#943970}
Roll Chrome Mac PGO profile from chrome-mac-main-1637538221-a4d5daecc1ca12eacf24bd0d92f483bee172db87.profdata to chrome-mac-main-1637559793-a5db364002774aa9325bc497f930d67364ab83f0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I48f674e66c6e32e0fc01f7ce4176a2e2e3881aa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3291796 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#943971}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ce9262ec60f6..fb519ae216ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC asamidoi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: asamidoi@google.com Change-Id: Icdf4e489a0bc3fb08317be4356a692e6172e2ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3291793 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#943972}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2e026b80d006..a992c9dfc6e3 2021-11-22 bmeurer@chromium.org Remove position adjustment for inline scripts with #sourceURL. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1183990,chromium:578269 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I75b97214dd4d6eb8e03594b693fd64a5213b6fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295322 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#943973}
New notifications for rollback + recommended or required update and slight improvements of existing notifications for consistency. Mocks: https://docs.google.com/document/d/15k5BTCdh9yErC-BBdPcjmv7Z8DPSHDPJVO8a77MkllI Bug: 876643 Change-Id: I2b6a8543c13fcc4cf035b09cd032f80e38fe6d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3282158 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Regan Hsu <hsuregan@chromium.org> Reviewed-by: Aya Elsayed <ayaelattar@chromium.org> Commit-Queue: Miriam Polzer <mpolzer@google.com> Cr-Commit-Position: refs/heads/main@{#943974}
Tests for basic navigation functionality that do not rely on access to internals. Bug: 1267091 Change-Id: Ic19dc3e188baf97e6836cebc9f2dfe23d8d8c666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295287 Commit-Queue: Fergal Daly <fergal@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/main@{#943975}
It was previously flaky due to console messages. Now it just tests what it should test. Fixed: 1271541 Change-Id: I92f5ae6bc1e349f38d82ddbd2d11bc0b8b3f0dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3292450 Commit-Queue: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#944169}
A significant number of crashes for Issue 1148542 actually have request urls that match the process' ProcessLock, but CanAccessDataForOrigin (CADFO) fails solely on account of all the BrowsingInstanceIDs for that process having been deleted. Since it seems possible that these requests could be from lingering JS running in the renderer process, it seems reasonable not to fail CADFO so long as the requested url matched the ProcessLock. This CL implements that strategy as a temporary approach to reduce crashes until a better solution for the no BrowsingInstance ID case is found. Bug: 1148542 Change-Id: I38f63c5f2059b3da419b0ba2b893c22263a32c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3270640 Commit-Queue: W. James MacLean <wjmaclean@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/main@{#944170}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ab50507898a4..d57bbc80be0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ldavidbaron@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1271924 Tbr: ldavidbaron@google.com Change-Id: I623dc6a6453f198633ed9c5d78bd5b327972d16c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295930 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#944171}
OWNERS file links are used when importing more owners from another file. Change-Id: Id772a06d922854d84d873455e08381120776917f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3290654 Auto-Submit: Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by: Brian Malcolm <bmalcolm@chromium.org> Cr-Commit-Position: refs/heads/main@{#944172}
Assign action type to search result action metadata, instead of relying on the action index within the actions vector to determine the action type. BUG=None Change-Id: Ie890bfb31828bba3b664afba320296ecb08b6567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3294968 Reviewed-by: Tony Yeoman <tby@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/main@{#944173}
When a signed-in synced user changes their Tailored Security account setting, we want to prompt them that Chrome Enhanced Safe Browsing was enabled. This Android message will prompt them. Added safety-check icon from chrome://settings/privacy. Screenshot at http://screen/6MvuRRSjRmwws9e.png Bug: 1257621 Change-Id: I4dea97896f6bb4eec90dc702cdf787e23a2a41f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3275315 Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Reviewed-by: Lijin Shen <lazzzis@google.com> Reviewed-by: Tomasz Wiszkowski <ender@google.com> Reviewed-by: Daniel Rubery <drubery@chromium.org> Commit-Queue: Rohit Bhatia <bhatiarohit@google.com> Cr-Commit-Position: refs/heads/main@{#944174}
https://crbug.com/1119402 moved Cronet's `min_sdk_version` GN arg from components/cronet/android/BUILD.gn to Cronet's CI builders GN args. This works fine for CI/CQ testing, where the test bots are properly configured, but causes failures when trying to test on a local device with an API level lower than the default one. Adding this parameter to the GN config generated by `cr_cronet.py gen` solves this problem. Bug: 1272488, b:207360164, 1119402 Change-Id: I072a5880bce4256e8327fff8b7db36ddb800b383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3296025 Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Stefano Duo <stefanoduo@google.com> Cr-Commit-Position: refs/heads/main@{#944175}
https://webrtc.googlesource.com/src.git/+log/f002e2fc9059..8ef7da78b37d 2021-11-22 titovartem@google.com [DVQA] Remove sender from DVQA StatsKey If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibe715809688be7463809ed203149bac5ccf3c13b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295940 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#944176}
Also removed the field trial testing config. The code cleanup will follow in subsequent CLs that will remove the feature flag, and old infobar code and tests. Bug: None Change-Id: If18aaa48c0baaa795ccaf2b7fcb735be187ec3f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3293581 Commit-Queue: Min Qin <qinmin@chromium.org> Auto-Submit: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/main@{#944177}
…ementation Addressing belated review feedback, no significant logic changes. Bug: 1164675, b/199294474 Change-Id: Iac1227ce14338cb16f011002b788b968c18db1a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3294047 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/main@{#944178}
No functional changes. Change-Id: I05087b6a64de33ee21b26c7146b48424c9337eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3296326 Commit-Queue: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#944179}
This test had expectations that basically say "fail", and on top of that the test has a flaky crash. Let's just delete this old plugins-related test. Fixed: 1271254 Change-Id: I5bde22cf049077619b0128ea73f1278825ddc773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3294044 Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#944180}
ErrorPageOfflineAppLaunchTest.DiagnosticsConnectivity is flakily failing on linux-chromeos-rel, disable for Chrome OS. Bug: 1267299 Change-Id: I90d71da5c7f1878e2eaa77956b9d222800bbd731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3296425 Auto-Submit: Katie Dektar <katie@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Owners-Override: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#944181}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7b0a00ed9ee0..f034f0b144e6 2021-11-22 marijnh@gmail.com Reland "Port the console prompt to CodeMirror 6" 2021-11-22 marijnh@gmail.com Limit the area where tooltips can show up 2021-11-22 victorporof@chromium.org Disable source map test for being flaky If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1241848,chromium:1272490 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I77113b677fc1f37f2ee7f29f1c77dd15cdea1cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295928 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#944182}
Responsiveness metrics use presentation callbacks to measure latency for events. For discrete events, if the event has no update, presentation callback might not be called until some other update happens in the page, causing large, inaccurate latencies for those events. With this CL, after events are processed on the main thread, if they don't cause any updates, outstanding swap promises are broken immediately. Bug: 1233222 Change-Id: I4c4e1c87a88019f5383aaf0947ce86e0222a3d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3249271 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Auto-Submit: Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/main@{#944183}
Bug: 1270923 Change-Id: I56c63402bb69d0a29ea27e730541eecad905c70f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3296327 Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/main@{#944184}
Adds support to convert battery info from device::BluetoothDevice to BluetoothDeviceProperties Change-Id: I0411e258d33a477b93b15ba49d3aef1bac59bc6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3283170 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Shane Fitzpatrick <shanefitz@google.com> Reviewed-by: Gordon Seto <gordonseto@google.com> Commit-Queue: Juliet Levesque <julietlevesque@google.com> Cr-Commit-Position: refs/heads/main@{#944185}
It was previously flaky due to console messages. Now it just tests what it should test. Fixed: 1271487 Change-Id: I54b1859aa6e4406c83732382475a2b01fb7a309f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3294101 Commit-Queue: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#944186}
By default, tests that use the ChromeJUnit4ClassRunner will have animations disabled. Tests that want to run animations should explicitly enabled them by adding the annotation @EnsureAnimationsOn. Bug: 1269920 Change-Id: I6bf611d9f5c948c5e7b2c3528fa9ec98621efe58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3278354 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/main@{#944187}
…l tree This CL updates the chrome://accessibility resources page for Android to make the accessibility tree dump show the final/external tree that is passed to the Android API, rather than the intermediate tree. As part of the continued "missing layer" work/fixes, we are updating the accessibility tree outputs on Android to leverage all layers of the accessibility code, including the Java-side logic, to make the outputs generated more substantial and meaningful for debugging purposes. Android is unique in that there are essentially 3 trees, the blink (internal tree), a platform tree, and the platform tree converted to match the Android API (external/post tree). The other platforms do not have this final step, so printing the platform tree is sufficient. However on Android, printing the platform tree can be misleading, as more business logic is performed before the final tree is sent to the Android API. Here we add a new accessibility tree formatter for this external facing tree and differentiate between internal, pre and post trees for Android only. Binary-Size: Looked into dex methods issue with binary size team. AX-Relnotes: When using chrome://accessibility on Android, the show accessibility tree button will now print the tree mapped to the Android API. Bug: 1258230 Change-Id: I275b1e916efced0e18330137c35261d265e26557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3265897 Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/main@{#944188}
This CL adds missing pair Bluetooth button to bluetooth devices subpage and also missing "no device connected" text. Screenshot: https://screenshot.googleplex.com/7CbcSM8546D8fm9.png Bug: 1010321 Change-Id: I4dde29cc32f56182b1c9b4240d7927b3b4e4e66a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3291771 Reviewed-by: Regan Hsu <hsuregan@chromium.org> Reviewed-by: Gordon Seto <gordonseto@google.com> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/main@{#944189}
https://skia.googlesource.com/skia.git/+log/bfafc430e850..d4bcb486efc5 2021-11-22 kjlubick@google.com Change relative includes to be absolute 2021-11-22 kjlubick@google.com Use angle brackets for system includes 2021-11-22 michaelludwig@google.com [graphite] Keep baseVertex,baseInstance relative to offset specified when vertex buffers were bound 2021-11-22 csmartdalton@google.com Drop support for indirect draws on ES 2021-11-22 herb@google.com replace GlyphRunList with its origin for draw() 2021-11-22 herb@google.com remove unused GrTextBlob* from calls If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Change-Id: I64cd82d3be2ae942c579e0bf3c5ec9ec050c92e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295937 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#944190}
This CL removes the CreateProcess hooks for the SUBSYS_PROCESS sandbox policy. It leaves in the other necessary hooks so doesn't remove the entire subsystem. Bug: 1058631 Change-Id: Ib37e54a5e1d65c038c429556c3d250cd49da0c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3293426 Reviewed-by: Alex Gough <ajgo@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/main@{#944191}
This CL re-enables a test that was disabled in 2011 by moving it to a separate test extension and the interactive_ui_tests suite, since it tests setting window focus. Bug: 58229 Change-Id: I07aeb9532fffd137144041d1cb21cf8a9bda0abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3261540 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/main@{#944192}
Instead of only counts. This gives better log output on failure. Change-Id: Ia474fa68a697dc5d5068065b5d0f6febc89ffae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3296302 Reviewed-by: Nan Lin <linnan@chromium.org> Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Cr-Commit-Position: refs/heads/main@{#944193}
Roll Chrome Mac PGO profile from chrome-mac-main-1637582157-9e01b98de0eefd02bfda0fdfe631c48c81b16a28.profdata to chrome-mac-main-1637603937-0a78d73fe6bffbfd20a4484fd1d9b5ee1fbf3bfb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iac42a985e1d247b76daabe02010c32424e66e8f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3296526 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#944194}
Disables virtual/gpu-rasterization/images/color-profile-svg-fill-text.html. Bug: 1272575 Change-Id: If19f01040d471eea36a236e7355cef37e85a9e4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3296443 Auto-Submit: Katie Dektar <katie@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Owners-Override: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#944195}
pull bot
pushed a commit
that referenced
this pull request
Jun 22, 2022
This TODO is obsolete now that PR #62 has been merged, closing issue #60. For references, see: w3c/mediacapture-region#62 w3c/mediacapture-region#60 Bug: 1333319 Change-Id: I7589b0f21dc2ae9808976062a927218d8c8198e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3716642 Commit-Queue: Jordan Bayles <jophba@chromium.org> Auto-Submit: Elad Alon <eladalon@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/main@{#1016221}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )