Add fmt as a dependency #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulling fmt 10.0.0 into third_party
danakj
force-pushed
the
add-fmt
branch
5 times, most recently
from
25167e6
to
8e8e26a
Compare
So that we can use fmt when rtti is disabled on clang/gcc
This allows IDEs and compiler errors to find the right source locations.
danakj
force-pushed
the
add-fmt
branch
6 times, most recently
from
5abab8f
to
1d6b6db
Compare
If the inner type is unformattable, it will be formatted as a string of byte values for the memory in the type. To do this we have helper formatters AnyFormatter and AnyOrVoidFormatter.
If you resolve the gtest templates in one TU to say that a type is not printable then it seems to cache it and affect other TUs. So stick it in prelude.h so it's always there.
This ensures that it is not possible for gtest users to end up including the type and printing it in one TU without stream support which then breaks printing it in another TU that also includes the stream support. They will simply always be printable by streams. This is done without including anything other than iosfwd (and string and fmt) in header files.
danakj
force-pushed
the
add-fmt
branch
4 times, most recently
from
c20e0d2
to
634288c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull fmt into third_party, and define formatters for all useful-to-print public types.