fix(bootstrap): fix import command handling of no input piped to stdin

[suchapalaver]

Improve information around stdin not being readable, quit if if it's not and standard in is not a tty.
CHRON-323

[mtbc]

I was thinking of something more like,

let data = if let Some(path) = matches.value_of("path") {
    let path = PathBuf::from(path);
    let data = std::fs::read_to_string(&path)?;
    info!("Loaded import data from {:?}", path);
    data
} else {
    if atty::is(atty::Stream::Stdin) {
      eprintln!("Attempting to import data from standard input, press Ctrl-D to finish.");
    }
    info!("Attempting to read import data from stdin...");
    let data = read_import_data()?;
    info!("Loaded {} bytes of import data from stdin", data.len());
    data
};

so, for instance, ... import myns my-ns-uuid gets the message about Ctrl-D, but ... import myns my-ns-uuid <from-my-data.json does not get the message printed even though, in terms of CLAP arguments, they're the same.

[suchapalaver]

I was thinking of something more like,

let data = if let Some(path) = matches.value_of("path") {
    let path = PathBuf::from(path);
    let data = std::fs::read_to_string(&path)?;
    info!("Loaded import data from {:?}", path);
    data
} else {
    if atty::is(atty::Stream::Stdin) {
      eprintln!("Attempting to import data from standard input, press Ctrl-D to finish.");
    }
    info!("Attempting to read import data from stdin...");
    let data = read_import_data()?;
    info!("Loaded {} bytes of import data from stdin", data.len());
    data
};

so, for instance, ... import myns my-ns-uuid gets the message about Ctrl-D, but ... import myns my-ns-uuid <from-my-data.json does not get the message printed even though, in terms of CLAP arguments, they're the same.

Could you give what you're suggesting a try? I think you and atty might have differing definitions of what a tty is. The inputs you're giving as examples don't behave the way you're expecting - branch here.

[mtbc]

I did try my suggestion before commenting. Have just done so again, still behaves exactly as I'd expect, so does your branch. If I give a filename or pipe something in, like from a file, I don't get the control+D message. If I leave it just attached to the terminal expecting input from that, I do get the message. Is that not what happens for you?

Maybe we can screenshare on Monday so I can see what you're seeing.

[suchapalaver]

I did try my suggestion before commenting. Have just done so again, still behaves exactly as I'd expect, so does your branch. If I give a filename or pipe something in, like from a file, I don't get the control+D message. If I leave it just attached to the terminal expecting input from that, I do get the message. Is that not what happens for you?

Maybe we can screenshare on Monday so I can see what you're seeing.

Could you share the exact command you used to get the Ctrl + D message path, please?

[mtbc]

mtbc@pop-os:~/src/chronicle$ git checkout origin/fix/what-is-a-tty
HEAD is now at 44a2049 fix(bootstrap): fix import command hanging if no input piped to stdin
mtbc@pop-os:~/src/chronicle$ git status
HEAD detached from origin/main
nothing to commit, working tree clean
mtbc@pop-os:~/src/chronicle$ cargo run --bin chronicle --features inmem -- import testns 60976119-adc6-3826-a57b-3ccb0580e7bd 
    Finished dev [unoptimized + debuginfo] target(s) in 0.18s
     Running `target/debug/chronicle import testns 60976119-adc6-3826-a57b-3ccb0580e7bd`
Attempting to import data from standard input, press Ctrl-D to finish.

[suchapalaver]

I did try my suggestion before commenting. Have just done so again, still behaves exactly as I'd expect, so does your branch. If I give a filename or pipe something in, like from a file, I don't get the control+D message. If I leave it just attached to the terminal expecting input from that, I do get the message. Is that not what happens for you?

Maybe we can screenshare on Monday so I can see what you're seeing.

Sorry! You were right! Don't know why I wasn't seeing it before. I made all your suggested changes.