Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix total config collapse on improper update #275

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

fzzyhmstrs
Copy link
Contributor

Resolves the numerous issues here and in the discord of the update causing all MCDW weapons to vanish.

Accomplishes this by adding "dummy" values to the various "____Stats" classes. Doing this seems to appease Jankson, and allows for the config generation to actually go through.

Behavior 9.0.1 -> 9.0.2: If configs aren't updated, all weapons fail to register (because they are "disabled"), all weapons in players inventories vanish permanently.
Behavior 9.0.1 -> 9.0.3: Config updates with the isEnabled flags, registry is maintained, and items stay intact.

…eleeWeaponID, IRangedWeaponID, and IShieldID
@fzzyhmstrs fzzyhmstrs changed the title Fix total vconfig collapse on improper update Fix total config collapse on improper update Apr 19, 2024
@fzzyhmstrs
Copy link
Contributor Author

Also I recommend adding a pull request template. It felt a little cheeky to do so on a PR itself, but a simple example can be found in Fzzy Config source: https://github.com/fzzyhmstrs/fconfig/blob/master/.github/pull_request_template.md. Importantly, this notifies the PR-maker that they are agreeing to be bound by the terms of the softwares license (the TDL in this case)

@chronosacaria chronosacaria merged commit bcb6725 into chronosacaria:1.20 Apr 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants