Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete weird feature guard #1582

Merged
merged 1 commit into from
May 23, 2024
Merged

Remove obsolete weird feature guard #1582

merged 1 commit into from
May 23, 2024

Conversation

djc
Copy link
Member

@djc djc commented May 23, 2024

This breaks CI on nightly because nightly is now checking for unknown features.

@djc djc requested a review from pitdicker May 23, 2024 07:43
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.78%. Comparing base (7e25ffb) to head (ee26904).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1582   +/-   ##
=======================================
  Coverage   91.78%   91.78%           
=======================================
  Files          37       37           
  Lines       18208    18208           
=======================================
  Hits        16713    16713           
  Misses       1495     1495           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pitdicker pitdicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line was last changed in db8784f. Seems to have been weird before that.

@djc djc merged commit ce38386 into main May 23, 2024
35 checks passed
@djc djc deleted the rm-broken-cfg branch May 23, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants