-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add base_sha option to clj-lint-action. #198
Conversation
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
=======================================
Coverage 86.90% 86.90%
=======================================
Files 77 77
Lines 6246 6246
Branches 519 519
=======================================
Hits 5428 5428
Misses 299 299
Partials 519 519 Continue to review full report at Codecov.
|
.github/workflows/lint.yml
Outdated
@@ -12,4 +12,5 @@ jobs: | |||
linters: "[\"clj-kondo\" \"kibit\" \"eastwood\"]" | |||
github_token: ${{ secrets.GITHUB_TOKEN }} | |||
runner: ":leiningen" | |||
base_sha: ${{ github.event.before }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry if I misunderstood, but I guess github.event.pull_request.base.sha
is more suitable for PR events since files eventually changed in a PR are more important than files changed in the last commit of a PR.
0444810
to
2039561
Compare
Thank you for the pointing. |
Hmm.. |
2039561
to
2cbda5a
Compare
For a non-master branch, I changed the action to pick up the changes from the beginning of the branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks for your quick response!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you 👍
This PR adds the option of clj-lint-action.
Without this option, the second commit on the branch would not be able to take the diff.