Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #61 (5) Examine result file of create-dict in test #64

Merged
merged 2 commits into from
Apr 25, 2017

Conversation

ayamada
Copy link
Contributor

@ayamada ayamada commented Apr 21, 2017

No description provided.

@codecov-io
Copy link

codecov-io commented Apr 21, 2017

Codecov Report

Merging #64 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage    82.4%   82.56%   +0.16%     
==========================================
  Files          56       55       -1     
  Lines        3285     3281       -4     
  Branches      363      362       -1     
==========================================
+ Hits         2707     2709       +2     
+ Misses        215      210       -5     
+ Partials      363      362       -1
Impacted Files Coverage Δ
src/cljam/main.clj
src/cljam/sorter.clj 79.31% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a65d3c...507f865. Read the comment docs.

(->> (map #(= (omit-ur %1) (omit-ur %2)) dict1 dict2)
(filter identity)
first
boolean)))))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this implementation right? This seems to return false only if all lines are different. (true if any pair of lines is equal.)

Is the following enough?

(->> (map #(= (omit-ur %1) (omit-ur %2)) dict1 dict2)
     (every? true?))

Additionally, VN:1.4 can be ignore. omit-vn is required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review, It is my mistake.
I fixed these problems ayamada@507f865 .

@totakke totakke merged commit f10a9cf into chrovis:master Apr 25, 2017
@totakke
Copy link
Member

totakke commented Apr 25, 2017

Thanks!

@ayamada ayamada deleted the feature/test-check-dict-file branch April 28, 2017 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants