-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #61 (5) Examine result file of create-dict
in test
#64
Conversation
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 82.4% 82.56% +0.16%
==========================================
Files 56 55 -1
Lines 3285 3281 -4
Branches 363 362 -1
==========================================
+ Hits 2707 2709 +2
+ Misses 215 210 -5
+ Partials 363 362 -1
Continue to review full report at Codecov.
|
test/cljam/t_dict.clj
Outdated
(->> (map #(= (omit-ur %1) (omit-ur %2)) dict1 dict2) | ||
(filter identity) | ||
first | ||
boolean))))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this implementation right? This seems to return false
only if all lines are different. (true
if any pair of lines is equal.)
Is the following enough?
(->> (map #(= (omit-ur %1) (omit-ur %2)) dict1 dict2)
(every? true?))
Additionally, VN:1.4
can be ignore. omit-vn
is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review, It is my mistake.
I fixed these problems ayamada@507f865 .
Thanks! |
No description provided.