Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with remote address lookup on the UPD6EndpointAdress object… #35

Merged
merged 1 commit into from
Jun 20, 2016

Conversation

nilsMontenegro
Copy link
Contributor

… when using IPv6. The remote address is located in the sockaddr.

… when using IPv6. The remote address is located in the sockaddr.
@chrysn
Copy link
Owner

chrysn commented Jun 20, 2016

Thanks for fixing this. It should actually be done differently, but that's a more generic issue now tracked in #40, and your fix does do the job until the greater scheme is figured out.

(Out of curiosity: are you using aiocoap for multicast requests? (I couldn't figure out any other situation that would trigger that code path). Support for that so far is rather rudimentary and not covered by tests yet, I'd be interested in hearing your experience.)

@chrysn chrysn merged commit 8b11ea2 into chrysn:master Jun 20, 2016
chrysn added a commit that referenced this pull request Jun 20, 2016
Discoered by nilsMontenegro, see [35].

[35]: #35
@nilsMontenegro
Copy link
Contributor Author

Hi, thanks for pulling this in.
I think the code is triggered because of IPv6 and not because of mulitcast.
We don't have multitast. We have a bluetooth low energy (BLE) device connected to the PC.
They communicate via 6lowpan, a kind of IPv6 over BLE.
The PC uses AIOCOAP as server and the BLE-kit holds the coap client with another implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants