We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently, the checkTool function has the following type:
checkTool
checkTool :: cmd -> Tool cmd -> IO ToolCheckResult
where ToolCheckResult is defined as follows:
ToolCheckResult
data ToolCheckResult = ToolNotFound Text | ToolWrongVersion Text | ToolOk
A value of ToolCheckResult is thrown as an exception here:
iris/src/Iris/Env.hs
Lines 138 to 141 in 6be65d4
This is suboptimal because the result can never have the ToolOk constructors but we're forcing downstream users to handle this case.
ToolOk
So we want to split success and error cases in the ToolCheckResult type.
The text was updated successfully, but these errors were encountered:
Resolves #33
a02e7f4
0b9c50d
charrsky
No branches or pull requests
Currently, the
checkTool
function has the following type:where
ToolCheckResult
is defined as follows:A value of
ToolCheckResult
is thrown as an exception here:iris/src/Iris/Env.hs
Lines 138 to 141 in 6be65d4
This is suboptimal because the result can never have the
ToolOk
constructors but we're forcing downstream users to handle this case.So we want to split success and error cases in the
ToolCheckResult
type.The text was updated successfully, but these errors were encountered: