Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GHC 9.4 #84

Closed
chshersh opened this issue Oct 6, 2022 · 2 comments 路 Fixed by #85
Closed

Support GHC 9.4 #84

chshersh opened this issue Oct 6, 2022 · 2 comments 路 Fixed by #85
Labels
CI good first issue Good for newcomers hacktoberfest https://hacktoberfest.com/
Milestone
v0.1.0.0: Improve...

Comments

@chshersh
Copy link
Owner

chshersh commented Oct 6, 2022

No description provided.

@chshersh chshersh added good first issue Good for newcomers CI hacktoberfest https://hacktoberfest.com/ labels Oct 6, 2022
@chshersh chshersh added this to the v0.1.0.0: Improved UX milestone Oct 6, 2022
@german1608
Copy link
Contributor

I can work on this :)

@german1608
Copy link
Contributor

german1608 commented Oct 7, 2022 •
edited

After taking a look, tasks needed for this would be:

  • Compile it with GHC 9.4.2 to see if there is any change we have to do.
  • Add GHC 9.4.2 to the CI build matrix
  • Update the Tested-With section of iris.cabal
  • Update the stack configuration (if needed)

@german1608 german1608 mentioned this issue Oct 7, 2022
Merged
3 tasks
chshersh added a commit that referenced this issue Oct 8, 2022
@german1608 @chshersh
[#84] Add support for GHC 9.4.2 (#85)
2efce7d 
Resolves #84 


* Add support for GHC 9.4.2
* Use only cabal 3.8
* Enable -Wredundant-strictness-flags for ghc >= 9.4
* Use hackage reference instead of git repository for colourista
* Add GHC 9.4.2 to tested-with
* Remove cabal version from cache key

Co-authored-by: Dmitrii Kovanikov <kovanikov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI good first issue Good for newcomers hacktoberfest https://hacktoberfest.com/
Projects
None yet
Milestone
v0.1.0.0: Improved UX
Development

Successfully merging a pull request may close this issue.

[#84] Add support for GHC 9.4.2 german1608/iris
2 participants
@chshersh @german1608