Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add macOS and Windows support on CI #53

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Add macOS and Windows support on CI #53

merged 2 commits into from
Jul 27, 2022

Conversation

charrsky
Copy link
Collaborator

Resolves #36 (had no issues with this one indeed)

@charrsky charrsky requested a review from chshersh as a code owner July 26, 2022 22:02
chshersh
chshersh requested changes Jul 27, 2022
View reviewed changes
Copy link
Owner

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, no problems as expected, the entire CI is green 🙂

I just have one suggestion to make CI slightly more optimal.

.github/workflows/ci.yml Show resolved Hide resolved
@charrsky charrsky self-assigned this Jul 27, 2022
chshersh
chshersh approved these changes Jul 27, 2022
View reviewed changes
Copy link
Owner

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 👏🏻

@chshersh chshersh merged commit 985a6b7 into chshersh:main Jul 27, 2022
@charrsky charrsky deleted the issue-36 branch July 27, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chshersh chshersh chshersh approved these changes

Assignees

@charrsky charrsky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Windows and macOS on CI
2 participants
@charrsky @chshersh