Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#74] Create Pull Request Template #76

Merged
merged 4 commits into from
Oct 6, 2022
Merged

[#74] Create Pull Request Template #76

merged 4 commits into from
Oct 6, 2022

Conversation

himanshu-malviya15
Copy link
Contributor

Created Pull Request Template
#74

@chshersh chshersh changed the title Created Pull Request Template [#74] Create Pull Request Template Oct 3, 2022
@chshersh chshersh added ⚗️ dx Dev experience improvements hacktoberfest-accepted https://hacktoberfest.com/participation/ labels Oct 3, 2022
chshersh
chshersh approved these changes Oct 3, 2022
View reviewed changes
Copy link
Owner

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for solving this so quickly! 👏🏻

@chshersh chshersh added the documentation Improvements or additions to documentation label Oct 3, 2022
chshersh
chshersh requested changes Oct 3, 2022
View reviewed changes
Copy link
Owner

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, Sorry, just noticed, that the file should be inside the .github directory and named PULL_REQUEST_TEMPLATE.md instead of top-level Pull Request Template.md

@himanshu-malviya15
Copy link
Contributor Author

@chshersh Changed Directory and name you can merge this PR

chshersh
chshersh approved these changes Oct 6, 2022
View reviewed changes
Copy link
Owner

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! All good now 🙂

@chshersh chshersh merged commit b768d6e into chshersh:main Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chshersh chshersh chshersh approved these changes

Assignees

@himanshu-malviya15 himanshu-malviya15

Labels
documentation Improvements or additions to documentation ⚗️ dx Dev experience improvements hacktoberfest-accepted https://hacktoberfest.com/participation/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@himanshu-malviya15 @chshersh