ci: add stan configuration #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
german1608
commented
Oct 4, 2022
|
https://github.com/chshersh/iris/actions/runs/3179437079/jobs/5186960223 job in this repository |
chshersh
added
CI
⚗️ dx
chshersh
requested changes
Oct 6, 2022
| @@ -120,3 +120,60 @@ jobs: | |||
| curl -L https://github.com/ndmitchell/hlint/releases/download/v${HLINT_VERSION}/hlint-${HLINT_VERSION}-x86_64-linux.tar.gz --output hlint.tar.gz | |||
| tar -xvf hlint.tar.gz | |||
| ./hlint-${HLINT_VERSION}/hlint src/ test/ | |||
|
|
|||
| stan: | |||
| name: stan | |||
There was a problem hiding this comment.
Can we add a GHC version to the name to quickly see what GHC is used?
Suggested change
| name: stan | |
| name: stan / ghc ${{ env.GHC_VERSION }} |
There was a problem hiding this comment.
Looks like env is not accessible on jobs.<job_id>.name 😢
https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability
Error on my fork: https://github.com/german1608/iris/actions/runs/3202338434/workflow
For now, we could hardwire the GHC version?
chshersh
reviewed
Oct 7, 2022
chshersh
approved these changes
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #64
The only warning we are getting is from the autogenerated files, as described on #64 (comment).
You can take a look at how does the action looks on my fork:
https://github.com/german1608/iris/actions/runs/3179426624/jobs/5181906133#step:10:1