-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add stan configuration #79
Conversation
https://github.com/chshersh/iris/actions/runs/3179437079/jobs/5186960223 job in this repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic!
I have a few further suggestions 🙂
Also, let's remove the .stan.toml
file. It's not needed if it's empty. We can always create it later when we need some custom configuration 🙂
@@ -120,3 +120,60 @@ jobs: | |||
curl -L https://github.com/ndmitchell/hlint/releases/download/v${HLINT_VERSION}/hlint-${HLINT_VERSION}-x86_64-linux.tar.gz --output hlint.tar.gz | |||
tar -xvf hlint.tar.gz | |||
./hlint-${HLINT_VERSION}/hlint src/ test/ | |||
|
|||
stan: | |||
name: stan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a GHC version to the name to quickly see what GHC is used?
name: stan | |
name: stan / ghc ${{ env.GHC_VERSION }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like env
is not accessible on jobs.<job_id>.name
😢
https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability
Error on my fork: https://github.com/german1608/iris/actions/runs/3202338434/workflow
For now, we could hardwire the GHC version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that CI is failing currently. Probably, only the name change is required to fix it. And it's good to go 🙂
Closes #64
The only warning we are getting is from the autogenerated files, as described on #64 (comment).
You can take a look at how does the action looks on my fork:
https://github.com/german1608/iris/actions/runs/3179426624/jobs/5181906133#step:10:1