[#94] Use Text in the simple-grep example to match changed Formatting API #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chshersh
added
the
hacktoberfest-accepted
|
@lillycat332 Do I understand correctly that #91 should be closed (currently it doesn't pass the CI) and this one should be merged instead? |
Yes, this would resolve both of them, since it has the same commits as the pr #91 |
chshersh
approved these changes
Jan 8, 2023
There was a problem hiding this comment.
Hey @lillycat332 👋🏻
Apologies for taking too long with the review. The PR looks great 🏆
So if you can rebase it on top of the latest main, I'm happy to merge it 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #94
Also fixes build issue with #91
Additional tasks