-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#94] Use Text in the simple-grep example to match changed Formatting API #95
Conversation
@lillycat332 Do I understand correctly that #91 should be closed (currently it doesn't pass the CI) and this one should be merged instead? |
Yes, this would resolve both of them, since it has the same commits as the pr #91 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lillycat332 👋🏻
Apologies for taking too long with the review. The PR looks great 🏆
So if you can rebase it on top of the latest main
, I'm happy to merge it 🎉
Resolves #94
Also fixes build issue with #91
Additional tasks