Update examples/ folder from stan analysis #98
Conversation
|
I would actually better fix Stan warning than ignoring it in examples. |
german1608
changed the title
german1608
force-pushed
the
exclude-examples-lhs-files-from-stan-report
branch
from
9ebcb61
to
1fb749d
Compare
|
Hey @german1608 👋🏻 There're some non-trivial git conflicts in this PR. I would appreciate if you could find the time to resolve them so I could merge the PR 🙏🏻 If you don't have the capacity, that's also fine, just let me know 🙂 |
|
@chshersh i will take a look this weekend. Thanks for letting me know 👍 |
german1608
force-pushed
the
exclude-examples-lhs-files-from-stan-report
branch
from
1fb749d
to
be69b45
Compare
examples/simple-grep/README.md
Outdated
| @@ -181,11 +181,11 @@ app = do | |||
| formattedPrinter "Starting grepping 🔥" Colourista.white | |||
| file <- liftIO $ TIO.readFile filePath | |||
|
|
|||
| let fileName = "file name: " `T.append` (last $ T.split (== '/') $ T.pack filePath) | |||
| let fileNameMessage = "file name: " `T.append` (last $ T.split (== '/') $ T.pack filePath) | |||
There was a problem hiding this comment.
Hmm, the last commit messages says that it uses takeFileName to get rid of the last function usage and remove Stan warning but I still see last here 🤔
Maybe something was lost during conflict resolution?
|
Hey @german1608 👋🏻 I have one last question about this PR. I would appreciate if you could find time to look into it 🙂 |
|
Hi @chshersh Sorry for the delay, had a lot of errands and events to attend. Taking a look at this |
german1608
force-pushed
the
exclude-examples-lhs-files-from-stan-report
branch
from
be69b45
to
8a1fe33
Compare
Not worth an issue I'd say, let me know otherwise :)
While working on #97 I noticed this:
Additional tasks