Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when opening from notification after app is closed #68

Closed
tulang3587 opened this issue Jul 17, 2019 · 1 comment · Fixed by #71
Closed

Crash when opening from notification after app is closed #68

tulang3587 opened this issue Jul 17, 2019 · 1 comment · Fixed by #71
Labels
bug Something isn't working

Comments

@tulang3587
Copy link

tulang3587 commented Jul 17, 2019

Describe the bug
When tapping the clear / notification item to clear / open the chucker activity, it crashses instead.

To Reproduce
Steps to reproduce the behavior:

  1. Do anything to show the chucker notification
  2. Kill the app, chucker notification still persists
  3. Tap clear button / the notification itself
  4. Crashes

Smartphone

  • OS: 8.0.0
  • Lib version: 3.0.0-alpha2

java.lang.IllegalStateException: You can't access the transaction repository if you don't initialize it! at com.chuckerteam.chucker.api.internal.data.repository.RepositoryProvider.transaction(RepositoryProvider.kt:16) at com.chuckerteam.chucker.api.internal.support.ClearTransactionsService.onHandleIntent(ClearTransactionsService.java:25) at android.app.IntentService$ServiceHandler.handleMessage(IntentService.java:68) at android.os.Handler.dispatchMessage(Handler.java:105) at android.os.Looper.loop(Looper.java:169) at android.os.HandlerThread.run(HandlerThread.java:65)


java.lang.IllegalStateException: You can't access the transaction repository if you don't initialize it! at com.chuckerteam.chucker.api.internal.data.repository.RepositoryProvider.transaction(RepositoryProvider.kt:16) at com.chuckerteam.chucker.api.internal.ui.transaction.TransactionListFragment.getDataSource(TransactionListFragment.java:136) at com.chuckerteam.chucker.api.internal.ui.transaction.TransactionListFragment.onAttach(TransactionListFragment.java:81) at androidx.fragment.app.FragmentManagerImpl.moveToState(FragmentManager.java:1404) at androidx.fragment.app.FragmentTransition.addToFirstInLastOut(FragmentTransition.java:1195)

@cortinico cortinico added the bug Something isn't working label Jul 31, 2019
redwarp pushed a commit to redwarp/chucker that referenced this issue Aug 2, 2019
Fixes ChuckerTeam#68
Clicking the notification after the app would have been closed or killed would trigger a crash because the repositories were only initialized when creating the Intercaptor
@cortinico
Copy link
Member

Thanks for reporting @tulang3587
That's actually a bug and #71 sounds like a great fix to me :)

cortinico pushed a commit that referenced this issue Aug 2, 2019
Fixes #68
Clicking the notification after the app would have been closed or killed would trigger a crash because the repositories were only initialized when creating the Intercaptor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants