-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: UI for locking canvas size aspect ratio #1172
Merged
leMaik
merged 13 commits into
chunky-dev:master
from
ShirleyNekoDev:feature-1125-lock-aspect-ratio
Mar 10, 2022
Merged
Feature: UI for locking canvas size aspect ratio #1172
leMaik
merged 13 commits into
chunky-dev:master
from
ShirleyNekoDev:feature-1125-lock-aspect-ratio
Mar 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShirleyNekoDev
force-pushed
the
feature-1125-lock-aspect-ratio
branch
from
February 17, 2022 18:08
cd1c9a2
to
7c7b5a8
Compare
Wow, the UI for this is amazing! 🤩 |
ShirleyNekoDev
force-pushed
the
feature-1125-lock-aspect-ratio
branch
from
February 25, 2022 12:12
7c7b5a8
to
0101d4f
Compare
~ fixed wrongly copy-pasted copyright notice |
ShirleyNekoDev
force-pushed
the
feature-1125-lock-aspect-ratio
branch
from
February 25, 2022 15:56
0101d4f
to
67bffb1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ShirleyNekoDev
force-pushed
the
feature-1125-lock-aspect-ratio
branch
from
February 26, 2022 10:13
67bffb1
to
37a42ca
Compare
~ rebased onto master |
ShirleyNekoDev
force-pushed
the
feature-1125-lock-aspect-ratio
branch
from
March 3, 2022 21:52
37a42ca
to
5719d35
Compare
~ rebased onto master (and messed up git on the way) |
leMaik
requested changes
Mar 5, 2022
leMaik
reviewed
Mar 5, 2022
leMaik
reviewed
Mar 5, 2022
leMaik
approved these changes
Mar 5, 2022
minor bug: one can enter a 0 in the image dimensions, which causes an exception and somehow the validation thinks it's fine I think the ratio/resize calculation has rounding issues.
|
…io locking support
Co-authored-by: Maik Marschner <m.marschner@wertarbyte.com>
ShirleyNekoDev
force-pushed
the
feature-1125-lock-aspect-ratio
branch
from
March 8, 2022 20:34
76c4142
to
e826c3e
Compare
leMaik
approved these changes
Mar 9, 2022
@Peregrine05 Can you create a new issue, please? |
All right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1125
This PR builds upon #1171