Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add versioned docs with macros. #85

Merged
merged 9 commits into from
Mar 12, 2023
Merged

Add versioned docs with macros. #85

merged 9 commits into from
Mar 12, 2023

Conversation

leMaik
Copy link
Member

@leMaik leMaik commented Dec 30, 2022

No description provided.

@leMaik leMaik changed the title Add versioned docs with macros. Draft: Add versioned docs with macros. Dec 30, 2022
@github-actions
Copy link

github-actions bot commented Dec 30, 2022 •
edited
Loading

PR Preview has been destroyed since this PR is closed.

jackjt8
jackjt8 approved these changes Dec 30, 2022
View reviewed changes
Copy link
Member

@jackjt8 jackjt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably best to merge alongside implementation of macros to all parts of the doc that require it. Though the site is functional without said changes.

@jackjt8
Copy link
Member

jackjt8 commented Dec 30, 2022

Closes #65 on merge.

@leMaik leMaik linked an issue Dec 30, 2022 that may be closed by this pull request
Support multiple versions of the doc #65
Closed
@leMaik
Copy link
Member Author

leMaik commented Dec 30, 2022 •
edited
Loading

@jackjt8 To keep the changes small, we could add makros to the content in future PRs. 🤔 I added a few examples.

@Peregrine05 Peregrine05 mentioned this pull request Jan 4, 2023
Closed
@Peregrine05 Peregrine05 mentioned this pull request Feb 1, 2023
Merged
@leMaik leMaik changed the title Draft: Add versioned docs with macros. Add versioned docs with macros. Mar 12, 2023
@leMaik leMaik merged commit e047048 into master Mar 12, 2023
@leMaik leMaik deleted the versioning branch March 12, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackjt8 jackjt8 jackjt8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support multiple versions of the doc
2 participants
@leMaik @jackjt8