Fixed issue where delete call was not awaited leading to a possible inconsistency
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… inconsistency when deleting and then reading a ref immediately afterwards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, similar to previous pull request, this addresses a condition where if you delete a ref and then immediately read it again the 'deleted' document still shows up. This is caused by not 'awaiting' the calls to
_deleteDirectoryand_deleteFile, so I added that. Also changed some of the 'existsSync' etc call to just await (not entirely sure but I believe it's better to not use the 'sync' calls and there is no need for it given you're already in an async function.