Free memory in destructor if not done before; adding copy constructor…

[chxdeng]

…/assignment operator

[coveralls]

Pull Request Test Coverage Report for Build 151

• 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.005%) to 98.366%

---

Totals
Change from base Build 147:	0.005%
Covered Lines:	1926
Relevant Lines:	1958

---

💛 - Coveralls

[spadalkar]

Should we also create operator for MBConfig?

Everything else looks good

[chxdeng]

MBConfig is a C-structure. I think we should be fine here with the default copy (by compiler) should be fine.

…

On Thu, Apr 26, 2018 at 11:08 PM, Satyajit Padalkar < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/db.cpp <#38 (comment)>: > +DB::DB(const DB &db) : status(MBError::NOT_INITIALIZED), + writer_lock_fd(-1) +{ + MBConfig db_config = db.dbConfig; + db_config.mbdir = db.mb_dir.c_str(); + InitDB(db_config); +} + +const DB& DB::operator = (const DB &db) +{ + if(this == &db) + return *this; // no self-assignment + + this->Close(); + + MBConfig db_config = db.dbConfig; Should we also create operator for MBConfig? Everything else looks good — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#38 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AcTVUQp9BVpYnQnhDI_qDGfeDVOpAm8kks5tsoubgaJpZM4TpJtp> .