Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow clients to get ownership of events #75

Merged
merged 2 commits into from
Jun 19, 2017
Merged

Allow clients to get ownership of events #75

merged 2 commits into from
Jun 19, 2017

Conversation

chris-m-h
Copy link
Contributor

Also: Optimize built-in Yaml deserializer to avoid one scalar value cloning step.

Not sure about the names, maybe somebody has a better idea?

Closes #74

Allow clients ownership of events
e14bdab 
Also: Optimize built-in Yaml deserializer to avoid one scalar value cloning step.
@chris-m-h
Copy link
Contributor Author

BTW: This pull request intents to preserve compatibility, and that is why the names get a bit clumsy.
Maybe a better solution would be to break compatibility and always return the Event by value. But that is a decision that I want to leave to you.

@chris-m-h chris-m-h mentioned this pull request Jun 18, 2017
Closed
dtolnay
dtolnay reviewed Jun 18, 2017
View reviewed changes
Copy link
Collaborator

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The current master branch already contains breaking changes compared to 0.3.5, so I agree that always returning the Event by value is a better solution.

@chris-m-h
Always pass events by value
7de2c38 
- The EventReceiver gets ownership of events
- Breaks compatilibility with previous interface
@chris-m-h
Copy link
Contributor Author

Compatibility is broken now - as agreed with @dtolnay
In this way, the interface does not get more convoluted.
Anyway, it should be trivial to update clients.

dtolnay
dtolnay approved these changes Jun 19, 2017
View reviewed changes
Copy link
Collaborator

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@dtolnay dtolnay merged commit d9024de into chyh1990:master Jun 19, 2017
@chris-m-h chris-m-h deleted the owned-events branch June 20, 2017 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-m-h @dtolnay