Bugfix in rewriteHistory #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, rewriteHistory was incorrect - it did not preserve the newlines between history lines, which corrupts the history file.
|
gentle ping - @chzyer could you please take a quick look at this? It's a one line fix. Thanks! |
|
Bump. Is this project still active? |
|
I don't think it is. The last response from the author was more than a year ago |
|
That would be a shame as it's still badly needed. @chzyer: Care to comment on your plans for the future? If you don't have the time or motivation currently, would you mind handing over maintainer-ship to someone else (at least temporarily)? Thanks for all the work so far! |
|
Just to leave here, |
|
Thanks all! I'm back :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, rewriteHistory was incorrect - it did not preserve the
newlines between history lines, which corrupts the history file.