feat: Support pagination for tab completion #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, maybe could be interesting for https://github.com/ergochat/readline? |
Thanks! Will make a PR there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hy @chzyer Don't know if this repo is still maintained, but we are using it for a command-line application that would need to tab-complete many choices (think ~1000), and the current implementation could not put those nicely on the terminal. I hacked a little feature to put the completions in pages and allow users to navigate pages using
JandKkeys in selection mode.I tested it for my workflow and it worked fine (I added an example
readline-paged-completionto showcase the feature, but I have not tested it thoroughly (e.g., vim mode and other stuff).