Networking - Docker Plugin - Data race on http server shutdown #29

mcastelino · 2016-04-12T16:26:36Z

The graceful http server has a data race on launcher invoked shutdown.

This commit replaces the use of the graceful HTTP server with the HTTP server provided by the Go standard library. After careful consideration it was determined that ciao does not currently need the functionality provided by this library. The graceful HTTP server tries to shut down all open connections before shutting down the HTTP server itself. However, we do not need to do this in ciao as we can be sure that the docker plugin's HTTP server can have no outstanding connections when it is asked to shutdown by ciao-launcher. Fixes ciao-project#29 Fixes ciao-project#221 Signed-off-by: Mark Ryan <mark.d.ryan@intel.com>

mcastelino added bug networking labels Apr 12, 2016

markdryan mentioned this issue Jun 7, 2016

networking: Get rid of graceful #221

Closed

markdryan self-assigned this Jun 24, 2016

markdryan added the in progress label Jun 24, 2016

markdryan mentioned this issue Jun 27, 2016

3rd party: Unvendor github.com/tylerb/graceful #319

Merged

mcastelino closed this as completed in ce36992 Jun 27, 2016

amyleeland removed the in progress label Jun 27, 2016

kaccardi added a commit to kaccardi/ciao that referenced this issue Aug 11, 2016

test ciao-project#29

04897f8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Networking - Docker Plugin - Data race on http server shutdown #29

Networking - Docker Plugin - Data race on http server shutdown #29

mcastelino commented Apr 12, 2016

Networking - Docker Plugin - Data race on http server shutdown #29

Networking - Docker Plugin - Data race on http server shutdown #29

Comments

mcastelino commented Apr 12, 2016