authenticateUser() should pass results of associateTokenToUser() to callback #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allback The authenticateUser() method of the OAuthServices class was returning the results of provider.authenticateUser() instead of provider.associateTokenToUser(). This gives incorrect results if associateTokenToUser() doesn't return the identical object (the in-memory provider does, which is probably why this doesn't come up). This patch changes the function so that if associateTokenToUser() returns a non-identical object (say, if you use a database) you get the most up-to-date object back.
ciaranj
added a commit
that referenced
this pull request
May 28, 2012
authenticateUser() should pass results of associateTokenToUser() to callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The authenticateUser() method of the OAuthServices class was returning
the results of provider.authenticateUser() instead of provider.associateTokenToUser().
This gives incorrect results if associateTokenToUser() doesn't return
the identical object (the in-memory provider does, which is probably why this doesn't come up).
This patch changes the function so that if associateTokenToUser()
returns a non-identical object (say, if you use a database) you get
the most up-to-date object back.