Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate random mnemonic words #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Generate random mnemonic words #7

wants to merge 1 commit into from

Conversation

9iks
Copy link

@9iks 9iks commented Apr 16, 2019

@ciband
Copy link
Owner

ciband commented Apr 16, 2019

@9iks Thank you for the PR.

It appears that CI is failing due to an issue with generating mnemonics. I think a duplicate word is being generated and failing the test but I have not ran it up to debug.

Are you able to investigate this test?

@9iks
Copy link
Author

9iks commented Apr 17, 2019

@9iks Thank you for the PR.

It appears that CI is failing due to an issue with generating mnemonics. I think a duplicate word is being generated and failing the test but I have not ran it up to debug.

Are you able to investigate this test?

Sorry, English is not my native language.
My OS :Mac 10.13.6
The complete project failed to compile because of the ~/bip39/make_dictionary/main.cpp file, line 18 references "experimental/filesystem".
I generate the bip39.xcodeproj file by executing the command "make -GXcode." in the ~/bip39/ src directory, and finally use xcode to compile the libbip39.a
In this source code, I simply appended "rbe.seed(std::random_device()());" to line 123 of the ~/bip39/src/bip39.cpp file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants