Make StanProgramBuilder available
#98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joewing
force-pushed
the
program-builder
branch
from
a061d65
to
1622263
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames
CodeBuildertoStanProgramBuilderand makes it available so that it can be used in end-user code. In particular, the use of certain Stan functions requires that an object of this type be passed implicitly, so writing a generic function that can be used in multiple models, for example, would require this.This PR also changes StanResults to avoid
printlnin the diagnostic functions, since that's not likely to go anywhere useful. Instead, the functions simply return the relevant information.Finally, this PR splits up
LinearRegressionto make it more modular, allowing one to create a custom regressions by mixing in traits.