Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select renderer relative path support for recordsPath option #423

Merged
merged 6 commits into from
May 31, 2017

Conversation

agonza40
Copy link
Contributor

This project uses semver, please check the scope of this pr:

  • #none# - documentation fixes and/or test additions
  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

CHANGELOG

Added support for relative paths for the recordsPath select renderer option
Fixed bunsenId, bunsenModel, and config assignment to cells from the inline array item component.

@cstolli
Copy link
Contributor

cstolli commented May 30, 2017

I think we need some tests on this stuff?

@cstolli
Copy link
Contributor

cstolli commented May 30, 2017

👍

Approved with PullApprove

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 31b4f53 on agonza40:master into ** on ciena-frost:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4e344ba on agonza40:master into ** on ciena-frost:master**.

@agonza40 agonza40 merged commit 9d79103 into ciena-frost:master May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants