Internal Models and model expansions. #432
Conversation
|
Changes Unknown when pulling 9ce6054 on agonza40:internal-models into ** on ciena-frost:master**. |
| const view = newProps.view ? this.getRenderView(model, newProps.view) : this.get('renderView') | ||
| const view = newProps.view | ||
| ? this.getRenderView(model, newProps.view) | ||
| : this.getRenderView(model, this.get('view')) |
There was a problem hiding this comment.
Does this mean that the view normalization is performed all the time on every store update?
There was a problem hiding this comment.
Yeah, I was having trouble getting the new normalized view from the computed property in the cases where I needed it. I think this can all be smoothed out with some slight restructuring of this component.
There was a problem hiding this comment.
Ok, lets hope this doesn't cause a performance regression. Can you double-check that the EVC example still runs smoothly with this change?
addon/utils.js
Outdated
| if (key === '_internal') { | ||
| return key | ||
| } | ||
| if (['boolean', 'number', 'string', 'undefined', 'null'].indexOf(typeof item) !== -1) { |
There was a problem hiding this comment.
I've been using [].includes to check existence in an array more than indexOf.
There was a problem hiding this comment.
That's what I was looking for! I was trying to use [].contains() which isn't a real thing.
addon/utils.js
Outdated
| if (subPaths.length <= 0) { | ||
| return | ||
| } | ||
| return _.map(subPaths, function (subPath) { |
There was a problem hiding this comment.
Any particular reason you're favoring _.map over map?
There was a problem hiding this comment.
I may have originally thought subPaths could be something other than an array.
addon/utils.js
Outdated
| return `${key}.${subPath}` | ||
| }) | ||
| }) | ||
| .filter() |
There was a problem hiding this comment.
So what does a filter with no args do?
There was a problem hiding this comment.
Filters out falsey values.
|
👍 |
|
👍 |
|
Changes Unknown when pulling 47535f4 on agonza40:internal-models into ** on ciena-frost:master**. |
This project uses semver, please check the scope of this pr:
CHANGELOG
Changed model expansions and internal models to take effect in nested objects.
Added support for internal models within arrays.