-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix frost-autocomplete filter not being populated via queryForCurrentValue, and have async filter show isloading
#539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… localFiltering when async
sophypal
previously approved these changes
Jul 18, 2018
addon/components/inputs/select.js
Outdated
) | ||
// let onlyQueryForCurrentValue = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to leave the comments in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops left those in by accident
sophypal
approved these changes
Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Does this PR close an existing issue?
No PR should be opened without opening an issue first. Any change needs to be discussed before proceeding.
Summary
Provide a general summary of the issue addressed in the title above
Issue Number(s)
Which issue(s) does this PR address?
Put
Closes #XXXX
below to auto-close the issue that this PR addresses:Screenshots or recordings
Please provide screenshots or recordings if this PR is modifying the visual UI or UX.
Checklist
Semver
This project uses semver, please check the scope of this PR:
Examples:
ember-hook
selectorsember-hook
selectorsCHANGELOG
queryForCurrentValue
not populating the filterfrost-autocomplete
showsisLoading
icon when doing an async search