Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move from ember-cli-blanket to ember-cli-code-coverage #80

Merged
merged 7 commits into from
Dec 20, 2016
Merged

move from ember-cli-blanket to ember-cli-code-coverage #80

merged 7 commits into from
Dec 20, 2016

Conversation

juwara0
Copy link
Contributor

@juwara0 juwara0 commented Dec 20, 2016 •
edited
Loading

This project uses semver, please check the scope of this pr:

  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

CHANGELOG

  • Updated repo to use ember-cli-code-coverage instead of ember-cli-blanket

@coveralls
Copy link

coveralls commented Dec 20, 2016 •
edited
Loading

Coverage Status

Changes Unknown when pulling 43f79fd on juwara0:updateCodeCoverage into ** on ciena-frost:master**.

dafortin
dafortin reviewed Dec 20, 2016
View reviewed changes
Copy link
Member

@dafortin dafortin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might have to delete tests/blanket-options.js and remove blanket from tests/index.html

@coveralls
Copy link

coveralls commented Dec 20, 2016 •
edited
Loading

Coverage Status

Changes Unknown when pulling d112453 on juwara0:updateCodeCoverage into ** on ciena-frost:master**.

@coveralls
Copy link

coveralls commented Dec 20, 2016 •
edited
Loading

Coverage Status

Changes Unknown when pulling 459702c on juwara0:updateCodeCoverage into ** on ciena-frost:master**.

@rox163
Copy link
Contributor

rox163 commented Dec 20, 2016 •
edited by job13er
Loading

👍

Approved with PullApprove

@juwara0 juwara0 merged commit acca2eb into ciena-frost:master Dec 20, 2016
@juwara0 juwara0 deleted the updateCodeCoverage branch December 20, 2016 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dafortin dafortin dafortin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juwara0 @coveralls @rox163 @dafortin