-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to ember-cli 2.12.3 #211
Conversation
Changes Unknown when pulling d9df1c0 on notmessenger:ember-cli-2.12.3 into ** on ciena-frost:master**. |
"chai-jquery": "^2.0.0", | ||
"ember-blog-engine": "git://github.com/srowhani/ember-blog-engine.git#caf6e66089b9639cbb076b5eeaa656161f91a5b9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's there to illustrate how you can mount engines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there something special about this repo and how it interacts with engines? Are links to engines different, etc? Is there something specific (needing to be) tested by doing so? Is it crucial that this happen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repo is the engine, it should not be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srowhani Is there something specific about the way that ember-frost-navigation
needs to mount an engine that it needs to have an example of doing so? Otherwise we're just replicating information about how to use ember-engines
that a user could get from reading ember-engine
's instructions, right, in what appears to be a random location for doing so? Any other repo could just as easily be used to illustrate how to mount engines, correct? I'm trying to ascertain if there is something special/specific about the relationship between ember-frost-navigation
and ember-engines
that I am not seeing.
Changes Unknown when pulling d724c95 on notmessenger:ember-cli-2.12.3 into ** on ciena-frost:master**. |
This project uses semver, please check the scope of this pr:
CHANGELOG
ember-cli
2.12.3