Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ember-cli 2.12.3 #211

Merged
merged 4 commits into from
Jul 12, 2017

Conversation

notmessenger
Copy link
Contributor

This project uses semver, please check the scope of this pr:

  • #none# - documentation fixes and/or test additions
  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

CHANGELOG

  • Upgrade to ember-cli 2.12.3

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d9df1c0 on notmessenger:ember-cli-2.12.3 into ** on ciena-frost:master**.

"chai-jquery": "^2.0.0",
"ember-blog-engine": "git://github.com/srowhani/ember-blog-engine.git#caf6e66089b9639cbb076b5eeaa656161f91a5b9",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srowhani @sglanzer Do either of you recall the reason for including this package and setting the dummy app up to use it? What was trying to be accomplished?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's there to illustrate how you can mount engines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something special about this repo and how it interacts with engines? Are links to engines different, etc? Is there something specific (needing to be) tested by doing so? Is it crucial that this happen?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repo is the engine, it should not be removed.

Copy link
Contributor Author

@notmessenger notmessenger Jul 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srowhani Is there something specific about the way that ember-frost-navigation needs to mount an engine that it needs to have an example of doing so? Otherwise we're just replicating information about how to use ember-engines that a user could get from reading ember-engine's instructions, right, in what appears to be a random location for doing so? Any other repo could just as easily be used to illustrate how to mount engines, correct? I'm trying to ascertain if there is something special/specific about the relationship between ember-frost-navigation and ember-engines that I am not seeing.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d724c95 on notmessenger:ember-cli-2.12.3 into ** on ciena-frost:master**.

@juwara0
Copy link
Contributor

juwara0 commented Jul 12, 2017

Approved

Approved with PullApprove

@juwara0 juwara0 merged commit 9eec295 into ciena-frost:master Jul 12, 2017
@notmessenger notmessenger deleted the ember-cli-2.12.3 branch August 14, 2017 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants