Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dismiss modal when clicking current route #218

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Dismiss modal when clicking current route #218

merged 1 commit into from
Oct 26, 2017

Conversation

TheOtherDude
Copy link
Contributor

This project uses semver, please check the scope of this pr:

  • #none# - documentation fixes and/or test additions
  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

CHANGELOG

  • Fixed a bug where clicking a nav-route targeting the current route would leave the modal open

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3ba1932 on TheOtherDude:currentRoute-dismiss into ** on ciena-frost:master**.

@notmessenger
Copy link
Contributor

notmessenger commented Oct 26, 2017 •
edited by dafortin
Loading

👍

Approved with PullApprove

@TheOtherDude TheOtherDude merged commit 447f920 into ciena-frost:master Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@job13er job13er Awaiting requested review from job13er

@juwara0 juwara0 Awaiting requested review from juwara0

@cstolli cstolli Awaiting requested review from cstolli

@sophypal sophypal Awaiting requested review from sophypal

Assignees
No one assigned
Labels
JIRA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheOtherDude @coveralls @notmessenger