Added ember-hook to components #41
Conversation
|
Changes Unknown when pulling f915247 on srowhani:master into * on ciena-frost:master*. |
|
Changes Unknown when pulling 57ed6dd on srowhani:master into * on ciena-frost:master*. |
| @@ -1,6 +1,6 @@ | |||
| {{#if isVisible}} | |||
| {{#if route}} | |||
| {{#frost-link route disabled=true}} | |||
| {{#frost-link route disabled=true hook=(concat hook '-link')}} | |||
There was a problem hiding this comment.
What happens if there are multiple 'route' menu items defined in a nav category? How would one distinguish them via the hook?
|
Changes Unknown when pulling b680791 on srowhani:master into * on ciena-frost:master*. |
1 similar comment
|
Changes Unknown when pulling b680791 on srowhani:master into * on ciena-frost:master*. |
|
README needs an update to show the hooks available. https://github.com/ciena-frost/ember-frost-sort#testing-with-ember-hook |
|
Changes Unknown when pulling b7a06e7 on srowhani:master into * on ciena-frost:master*. |
|
Changes Unknown when pulling b7a06e7 on srowhani:master into * on ciena-frost:master*. |
|
Changes Unknown when pulling b7a06e7 on srowhani:master into * on ciena-frost:master*. |
| | inline action from section context | `$hook('frost-nav-modal-section-<sectionIndex>-action-<actionIndex>')` | | ||
| | route hook | `$hook('frost-nav-modal-section-<sectionIndex>-route-<routeIndex>')` | | ||
| | frost-link within the route / action context | `$hook('frost-nav-modal-section-<sectionIndex>-(route / action)-<index>-link')` | | ||
| | action from section actions context | `$hook('frost-nav-modal-section-actions-action-<index>')` | |
There was a problem hiding this comment.
does the section need an index here as well?
There was a problem hiding this comment.
I dont like this name....'actions-action'. Can we make it a bit shorter?
|
👍 |
|
Changes Unknown when pulling e589b7e on srowhani:master into * on ciena-frost:master*. |
1 similar comment
|
Changes Unknown when pulling e589b7e on srowhani:master into * on ciena-frost:master*. |
patch