Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vertical tabs #63

Merged
merged 4 commits into from
Aug 25, 2017
Merged

Conversation

quincyle
Copy link
Contributor

@quincyle quincyle commented Aug 25, 2017

This project uses semver, please check the scope of this pr:

  • #none# - documentation fixes and/or test additions
  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

image

CHANGELOG

  • Added option to use a vertical tab.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling aa45822 on quincyle:vertical-tabs into ** on ciena-frost:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling aa45822 on quincyle:vertical-tabs into ** on ciena-frost:master**.

</div>
<div class='addon-demo-notes'>
<p>
It's possible to use an alternative vertical tab by passing degisn='vertical'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling -> design

@@ -62,7 +62,7 @@ describe(test.label, function () {
})
})

it('Renders', function (done) {
it('Renders ', function (done) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to add the extra space here?

@EWhite613
Copy link
Contributor

EWhite613 commented Aug 25, 2017

Approved

Approved with PullApprove

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 611d01e on quincyle:vertical-tabs into ** on ciena-frost:master**.

@quincyle quincyle merged commit e12c311 into ciena-frost:master Aug 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants