Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestAfkakClientIntegration.test_send_offset_request failure #89

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

twm
Copy link
Collaborator

@twm twm commented Jun 17, 2019

A fix for this failure seen on #37:

[ERROR]
Traceback (most recent call last):
  File "/home/travis/build/ciena/afkak/.tox/py27-int-snappy-murmur/lib/python2.7/site-packages/twisted/internet/defer.py", line 1416, in _inlineCallbacks
    result = result.throwExceptionIntoGenerator(g)
  File "/home/travis/build/ciena/afkak/.tox/py27-int-snappy-murmur/lib/python2.7/site-packages/twisted/python/failure.py", line 512, in throwExceptionIntoGenerator
    return g.throw(self.type, self.value, self.tb)
  File "/home/travis/build/ciena/afkak/.tox/py27-int-snappy-murmur/lib/python2.7/site-packages/afkak/test/int/test_client_integration.py", line 130, in test_send_offset_request
    [resp] = yield self.client.send_offset_request([req])
  File "/home/travis/build/ciena/afkak/.tox/py27-int-snappy-murmur/lib/python2.7/site-packages/twisted/internet/defer.py", line 1418, in _inlineCallbacks
    result = g.send(result)
  File "/home/travis/build/ciena/afkak/.tox/py27-int-snappy-murmur/lib/python2.7/site-packages/afkak/client.py", line 706, in send_offset_request
    returnValue(self._handle_responses(resps, fail_on_error, callback))
  File "/home/travis/build/ciena/afkak/.tox/py27-int-snappy-murmur/lib/python2.7/site-packages/afkak/client.py", line 763, in _handle_responses
    BrokerResponseError.raise_for_errno(resp.error, resp)
  File "/home/travis/build/ciena/afkak/.tox/py27-int-snappy-murmur/lib/python2.7/site-packages/afkak/common.py", line 311, in raise_for_errno
    raise subcls(*args)
afkak.common.NotLeaderForPartitionError: error=6 (NOT_LEADER_FOR_PARTITION) OffsetResponse(topic=u'test_send_offset_request-SMTPHcxJLm', partition=0, error=6, offsets=())
afkak.test.int.test_client_integration.TestAfkakClientIntegration.test_send_offset_request

Simply wait for topic auto-create to complete.

@twm
Copy link
Collaborator Author

twm commented Jun 17, 2019

(This includes changes from #87 so that should be reviewed and merged first.)

@twm twm requested a review from a team June 18, 2019 20:08
@twm
Copy link
Collaborator Author

twm commented Jun 24, 2019

Thanks @gobolt!

@twm twm merged commit 0738c1f into master Jun 24, 2019
@twm twm deleted the failure2 branch June 24, 2019 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants