Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capítulo iteración y datos relacionales #89

Merged
merged 7 commits into from
Jul 29, 2019
Merged

capítulo iteración y datos relacionales #89

merged 7 commits into from
Jul 29, 2019

Conversation

pachadotdev
Copy link
Member

No description provided.

21-iteration.Rmd Outdated Show resolved Hide resolved
21-iteration.Rmd Outdated Show resolved Hide resolved
21-iteration.Rmd Outdated Show resolved Hide resolved
21-iteration.Rmd Outdated Show resolved Hide resolved
21-iteration.Rmd Outdated Show resolved Hide resolved
21-iteration.Rmd Outdated Show resolved Hide resolved
@frm1789
Copy link

frm1789 commented Jul 18, 2019

Hasta aqui mis comentarios sobre este capitulo.

@pachadotdev
Copy link
Member Author

gracias @frm1789 !!!!!!!

@pachadotdev
Copy link
Member Author

pachadotdev commented Jul 20, 2019

@rivaquiroga está listo esto con los cambios pedidos
eso si hay un problema, no puedo hacer otro PR con relational-data traducido

@pachadotdev pachadotdev changed the title capítulo iteración capítulo iteración y datos relacionales Jul 20, 2019
@pachadotdev pachadotdev requested a review from frm1789 July 20, 2019 21:36
@rivaquiroga
Copy link
Member

ok, no hay problema.
@monialo2000, este es el enlace directo al archivo con la traducción de Datos relacionales: https://github.com/cienciadedatos/r4ds/pull/89/files#diff-972b277bed9fe88a054a82567dcdd357
(lo indico porque hay 212 archivos en el commit 😧)

@monialo2000
Copy link

monialo2000 commented Jul 22, 2019 via email

@pachadotdev
Copy link
Member Author

gracias @rivaquiroga y @monialo2000
he sacado varias cosas como los directorios de cache que se salieron del gitignore
ahora son mucho menos archivos

@frm1789
Copy link

frm1789 commented Jul 26, 2019

@pachamaltese Tenia un pedido de review al cual le di aprobación, pero hasta acá puedo llegar. Saludos,

@pachadotdev
Copy link
Member Author

@frm1789 muchas gracias, falta la otra parte del review que era la de @monialo2000

@monialo2000
Copy link

monialo2000 commented Jul 26, 2019 via email

13-relational-data.Rmd Outdated Show resolved Hide resolved
13-relational-data.Rmd Outdated Show resolved Hide resolved
13-relational-data.Rmd Outdated Show resolved Hide resolved
13-relational-data.Rmd Outdated Show resolved Hide resolved
13-relational-data.Rmd Outdated Show resolved Hide resolved
it contained weather records for all airports in the USA, what additional
relation would it define with `flights`?
1. Sabemos que hay días "especiales" en el año y pocas personas vuelan esos días.
¿Cómo se representarían en un data frame? ¿Cuáles serían las llaves primarias de esa tabla?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En Argentina usamos el termino clave en vez de llave...clave primaria, en vez de llave primaria. Pero quizá se decidió traducir asi. Lo comento en esta linea solamente.

1. `datos::vehiculos`
1. `datos::diamantes`

(Puede que necesites leer un poco de documentación.)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puede que necesites instalar algunos paquetes y leer un poco de documentación

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acá pasa todo a datos por lo que lo de "instalar más" pierde sentido

@pachadotdev pachadotdev merged commit 4708aed into cienciadedatos:traduccion Jul 29, 2019
Copy link

@monialo2000 monialo2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Llegué hasta Ejercicios, linea 383.

13-relational-data.Rmd Show resolved Hide resolved
13-relational-data.Rmd Show resolved Hide resolved
13-relational-data.Rmd Show resolved Hide resolved
13-relational-data.Rmd Show resolved Hide resolved
13-relational-data.Rmd Show resolved Hide resolved
13-relational-data.Rmd Show resolved Hide resolved
13-relational-data.Rmd Show resolved Hide resolved
@pachadotdev
Copy link
Member Author

pachadotdev commented Jul 30, 2019 via email

@pachadotdev
Copy link
Member Author

gracias! he incorporado estos cambios, quedo atento a los demás para enviar un nuevo pull request con estas nuevas observaciones

13-relational-data.Rmd Show resolved Hide resolved
13-relational-data.Rmd Show resolved Hide resolved
13-relational-data.Rmd Show resolved Hide resolved
13-relational-data.Rmd Show resolved Hide resolved
13-relational-data.Rmd Show resolved Hide resolved
13-relational-data.Rmd Show resolved Hide resolved
13-relational-data.Rmd Show resolved Hide resolved
13-relational-data.Rmd Show resolved Hide resolved
13-relational-data.Rmd Show resolved Hide resolved
13-relational-data.Rmd Show resolved Hide resolved
@monialo2000
Copy link

Aqui termina mi review de este capítulo. Gran trabajo Pachá!

@pachadotdev
Copy link
Member Author

gracias @monialo2000 !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants