ci: add golangci #44
Merged
ci: add golangci #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaworu
requested review from
a team and
jrfastab
and removed request for
a team
kaworu
force-pushed
the
pr/kaworu/golangci
branch
from
ba79aef
to
7276eb3
Compare
Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
kaworu
force-pushed
the
pr/kaworu/golangci
branch
2 times, most recently
from
7e4a031
to
b2ab400
Compare
rolinh
approved these changes
Dec 20, 2021
gandro
approved these changes
Dec 21, 2021
| HubbleServerCertValidityDuration = 3 * 365 * 24 * time.Hour | ||
| // HubbleServerCertSecretName is the Kubernetes Secret in which the Hubble | ||
| // server certificate is written to. | ||
| HubbleServerCertSecretName = "hubble-server-certs" //#nosec |
There was a problem hiding this comment.
What was the linter complaining about here?
There was a problem hiding this comment.
If you are asking about the //#nosec, it's because of
internal/defaults/defaults.go:58:2: G101: Potential hardcoded credentials (gosec)
HubbleServerCertSecretName = "hubble-server-certs"
b2ab400
to
6e84eaa
Compare
And fix complains on the way. Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration adapted from cilium/hubble.