Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectivity: Skip IPv6 requests in north-south-loadbalancing-with-l7-policy when running on < 1.14.0 Cilium #1627

Closed
brb opened this issue May 12, 2023 · 0 comments · Fixed by #1629
Assignees
Labels
area/CI Continuous Integration testing issue or flake

Comments

@brb
Copy link
Member

brb commented May 12, 2023

cilium/cilium#21954 for the IPv6 path was resolved only for v1.14, but not for v1.13. In order to be able to run the latest connectivity tests on v1.13, we need to skip curl requests to the IPv6 addresses in that particular test.

Ideally, the skip condition in the outsideToNodePort should be based on Cilium version and whether there are any L7 netpols installed. This is because the same test case is being used by north-south-loadbalancing which is not prone to the IPv6 issue.

@brb brb added the area/CI Continuous Integration testing issue or flake label May 12, 2023
brb added a commit to cilium/cilium that referenced this issue May 12, 2023
Unfortunately, 93baa34 was ran against the latest Cilium, so it didn't
catch v1.13 specific issues (limitations). This commit fixes:

* Use --tunnel instead of --tunnelProtocol. The latter was only
  introduced in v1.14 [1].
* Disable IPv6 for IPsec configuration.
* Downgrade CLI to v0.13.2 until [2] has been resolved.
* Remove external CIDRs, as they are not needed for v0.13.2 CLI.
* Disable L7 if EGW or WG is enabled (v1.13 limitation).
* Remove host-to-host encryption configurations (v1.13 doesn't support
  it).

[1]: #24561
[2]: cilium/cilium-cli#1627

Fixes: 93baa34 ("ci-e2e: backport changes in conformance-e2e into v1.13 tests")
Signed-off-by: Martynas Pumputis <m@lambda.lt>
thorn3r added a commit to cilium/cilium that referenced this issue May 12, 2023
The CLI version has been downgraded to v0.13.2 until
cilium/cilium-cli#1627 has been resolved.

This commit disables renovate on the ci-e2e-v1.13 workflow until the
issue has been resolved to prevent unintentional upgrade.

Signed-off-by: Tim Horner <timothy.horner@isovalent.com>
aanm pushed a commit to cilium/cilium that referenced this issue May 12, 2023
Unfortunately, 93baa34 was ran against the latest Cilium, so it didn't
catch v1.13 specific issues (limitations). This commit fixes:

* Use --tunnel instead of --tunnelProtocol. The latter was only
  introduced in v1.14 [1].
* Disable IPv6 for IPsec configuration.
* Downgrade CLI to v0.13.2 until [2] has been resolved.
* Remove external CIDRs, as they are not needed for v0.13.2 CLI.
* Disable L7 if EGW or WG is enabled (v1.13 limitation).
* Remove host-to-host encryption configurations (v1.13 doesn't support
  it).

[1]: #24561
[2]: cilium/cilium-cli#1627

Fixes: 93baa34 ("ci-e2e: backport changes in conformance-e2e into v1.13 tests")
Signed-off-by: Martynas Pumputis <m@lambda.lt>
aanm pushed a commit to cilium/cilium that referenced this issue May 12, 2023
The CLI version has been downgraded to v0.13.2 until
cilium/cilium-cli#1627 has been resolved.

This commit disables renovate on the ci-e2e-v1.13 workflow until the
issue has been resolved to prevent unintentional upgrade.

Signed-off-by: Tim Horner <timothy.horner@isovalent.com>
jschwinger233 added a commit to jschwinger233/cilium-cli that referenced this issue May 15, 2023
…-policy when running on < 1.14.0 Cilium

cilium/cilium#21954 for the IPv6 path was
resolved only for v1.14, but not for v1.13. In order to be able to run
the latest connectivity tests on v1.13, we need to skip curl requests to
the IPv6 addresses in that particular test.

Fixes: cilium#1627

Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
jschwinger233 added a commit to jschwinger233/cilium-cli that referenced this issue May 15, 2023
…-policy when running on < 1.14.0 Cilium

cilium/cilium#21954 for the IPv6 path was
resolved only for v1.14, but not for v1.13. In order to be able to run
the latest connectivity tests on v1.13, we need to skip curl requests to
the IPv6 addresses in that particular test.

Fixes: cilium#1627

Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
jschwinger233 added a commit to jschwinger233/cilium-cli that referenced this issue May 17, 2023
…-policy when running on < 1.14.0 Cilium

cilium/cilium#21954 for the IPv6 path was
resolved only for v1.14, but not for v1.13. In order to be able to run
the latest connectivity tests on v1.13, we need to skip curl requests to
the IPv6 addresses in that particular test.

Fixes: cilium#1627

Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
jschwinger233 added a commit to jschwinger233/cilium-cli that referenced this issue May 18, 2023
…-policy when running on < 1.14.0 Cilium

cilium/cilium#21954 for the IPv6 path was
resolved only for v1.14, but not for v1.13. In order to be able to run
the latest connectivity tests on v1.13, we need to skip curl requests to
the IPv6 addresses in that particular test.

Fixes: cilium#1627

Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
@brb brb closed this as completed in #1629 May 19, 2023
brb pushed a commit that referenced this issue May 19, 2023
…-policy when running on < 1.14.0 Cilium

cilium/cilium#21954 for the IPv6 path was
resolved only for v1.14, but not for v1.13. In order to be able to run
the latest connectivity tests on v1.13, we need to skip curl requests to
the IPv6 addresses in that particular test.

Fixes: #1627

Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake
Projects
None yet
2 participants