fsnotify: correctly check for event operation #13325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsnotify Event.Op is a bit mask and testing for strict equality might not detect the event operation correctly. This patch make it so we check for fsnotify event operation consistently as documented at https://github.com/fsnotify/fsnotify. Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
kaworu
added
priority/low
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
kaworu
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
tklauser
approved these changes
Sep 29, 2020
rolinh
approved these changes
Sep 29, 2020
|
test-me-please |
|
@kaworu This probably needs backporting, right? |
christarazi
approved these changes
Sep 29, 2020
|
retest-runtime |
This was referenced Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Backporting for v1.7 will fail to apply the ipmasq part of the patch as ipmasq isn't in v1.7 and can safely be ignored.
fsnotify Event.Op is a bit mask and testing for strict equality might
not detect the event operation correctly.
This patch make it so we check for fsnotify event operation
consistently as documented at https://github.com/fsnotify/fsnotify.