[v1.9] hubble/observer: use event timestamp when a time range is set #14197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manually cherry-picked from #14168 When r.timeRange is set but the received event is not a v1.Flow (i.e. e.GetFlow() is nil), v1.Flow(nil).GetTime() will return nil and lead to a panic. So far, this wasn't triggered in CI because the only other option for e.Event.(type) was *flowpb.LostEvent. These are very uncommon and hard to trigger in CI, thus the failure was not observed to far. Fix this by using e.Timestamp consistently which is always set. Reference: #14168 (comment) Reference: #14168 (comment) Fixes: f40c4ce ("hubble: Import server-side Hubble code") Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
added
kind/backports
|
test-backport-1.9 |
|
retest-runtime Hit #14125 https://jenkins.cilium.io/job/Cilium-PR-Runtime-4.9/2765/ |
rolinh
approved these changes
Nov 27, 2020
gandro
approved these changes
Nov 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually cherry-picked fix from #14168
When r.timeRange is set but the received event is not a v1.Flow (i.e.
e.GetFlow() is nil), v1.Flow(nil).GetTime() will return nil and lead to
a panic. So far, this wasn't triggered in CI because the only other
option for e.Event.(type) was *flowpb.LostEvent. These are very uncommon
and hard to trigger in CI, thus the failure was not observed to far.
Fix this by using e.Timestamp consistently which is always set.
Reference: #14168 (comment)
Reference: #14168 (comment)
Fixes: f40c4ce ("hubble: Import server-side Hubble code")