Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.9] docs: Add quick-hubble-install.yaml method #14468

Merged
merged 3 commits into from
Jan 21, 2021

Conversation

gandro
Copy link
Member

@gandro gandro commented Dec 21, 2020

This PR documents a simplified version to install Hubble Relay. The new variant will be available with the next release of Cilium 1.9. Users of Cilium 1.9.0/1.9.1 will need to fall back on Helm. The commits are a modified backport of the documentation changes in #14221.

Therefore, this PR should not be merged until 1.9.2 has been released, to avoid referencing an unreleased version in the 1.9 docs (as discussed in #14221 (comment))

[ upstream commit 8e9c494 ]

This adds the `quick-hubble-install.yaml` installation method to the
"Enable Hubble" section.

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
@gandro gandro added the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Dec 21, 2020
@gandro gandro requested a review from a team as a code owner December 21, 2020 15:23
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.9 kind/backports This PR provides functionality previously merged into master. labels Dec 21, 2020
Depending on the Cilium 1.9.x version, the installation method differs.
The `--set hubble.listenAddress=":4244"` is added back for users who
have not yet upgraded to 1.9.2. On 1.9.2 it is a no-op.

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
[ upstream commit 1c55bc2 ]

This adds the hubble-enable.rst section to more installation guides.

The Hubble section is still missing from some installation methods, such
as kops, microk8s, and okd/openshift, as they rely neither on `helm
install`, nor `quick-install.yaml` and likely need custom instructions.

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
@gandro gandro force-pushed the pr/gandro/v1.9-hubble-enable-docs-simplification branch from e2240b9 to ed4b7db Compare December 21, 2020 15:25
@gandro gandro added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. sig/hubble Impacts hubble server or relay labels Dec 21, 2020
@rolinh rolinh self-assigned this Jan 20, 2021
@gandro gandro added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs labels Jan 20, 2021
@rolinh rolinh merged commit d55fcdd into v1.9 Jan 21, 2021
@rolinh rolinh deleted the pr/gandro/v1.9-hubble-enable-docs-simplification branch January 21, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. sig/hubble Impacts hubble server or relay
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants