v1.9 backports 2021-03-08 #15254
Merged
v1.9 backports 2021-03-08 #15254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit 8105ca4 ] Use new options instead of these deprecated fields to avoid deprecation warnings: - RouteAction.max_grpc_timeout - Cluster.protocol_selection - Cluster.http2_protocol_options Define runtime option "overload.global_downstream_max_connections" to avoid a warning like: "there is no configured limit to the number of allowed active connections. Set a limit via the runtime key overload.global_downstream_max_connections" Fixes: #14919 Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
[ upstream commit 79d0719 ] Instruct users to pull the Cilium image before disabling 'systemd-resolved.service'. Mention that the port 2379 needs to be explicitly given in LoadBalancer instructions. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
maintainer-s-little-helper
bot
added
backport/1.9
kind/backports
jrajahalme
added
kind/backports
|
test-backport-1.9 |
Update Envoy API to be able to compile without using deprecated fields. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
|
test-backport-1.9 |
1 similar comment
|
test-backport-1.9 |
[ upstream commit 2df25bb ] protobuf.Message may contain a mutex, which trips the go vet linter in the CI. Fix by using .String() instead on debug messages, and using a pointer to transfer ownership rather than a copy. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
[ upstream commit 57b25c5 ] The updated protobuf implementation contains cyclical data structures and unexported fields that can not be compared. Add a new checker "ExportedEquals" that only compares exported fields of the given data structures. This ignoring of unexported fields is not safe for comparing arbitrary data structures which may store internal state in unexported fields. Use this new "ExportedEquals" checker to compare protobuf Messages. This avoids comparing global data structures pointer to by protobuf implementation specific fields. Avoid infinite recursion by keeping track which pointers have already been followed. Change existing use of checker.Equals to use simple Equals or HasLen instead when possible. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
jrajahalme
force-pushed
the
pr/v1.9-backport-2021-03-08
branch
from
bf994a0
to
5a87474
Compare
|
test-backport-1.9 |
|
Unrelated fail #15255 on test-1.12-netnext |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the last two commits of #14462 were backported, and after #15232, as they contained necessary Envoy API v3 fixes not previously backported to v1.9.
Once this PR is merged, you can update the PR labels via: