Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: Update links in values.yaml #18471

Merged
merged 1 commit into from
Jan 17, 2022
Merged

helm: Update links in values.yaml #18471

merged 1 commit into from
Jan 17, 2022

Conversation

sayboras
Copy link
Member

This commit is to update invalid links to correct one.

Signed-off-by: Tam Mach tam.mach@isovalent.com

helm: Update links in values.yaml

@sayboras sayboras requested review from a team as code owners January 13, 2022 13:32
@sayboras sayboras requested review from a team and joestringer January 13, 2022 13:32
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 13, 2022
@sayboras sayboras requested a review from kaworu January 13, 2022 13:32
@sayboras sayboras requested a review from aanm January 13, 2022 13:32
@sayboras sayboras added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/helm Impacts helm charts and user deployment experience release-note/misc This PR makes changes that have no direct user impact. labels Jan 13, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 13, 2022
@sayboras sayboras force-pushed the tam/helm-update-invalid-links branch from fb012b8 to b73b4eb Compare January 13, 2022 13:36
@kaworu
Copy link
Member

kaworu commented Jan 13, 2022

Good catch!

joestringer
joestringer requested changes Jan 13, 2022
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. Just one small change noted below.

install/kubernetes/cilium/README.md Outdated Show resolved Hide resolved
@sayboras sayboras force-pushed the tam/helm-update-invalid-links branch from b73b4eb to de9a3b5 Compare January 13, 2022 22:44
@sayboras
helm: Update links in values.yaml
7218d8b 
This commit is to update invalid links to correct one.

Signed-off-by: Tam Mach <tam.mach@isovalent.com>
@sayboras sayboras force-pushed the tam/helm-update-invalid-links branch from de9a3b5 to 7218d8b Compare January 13, 2022 22:45
joestringer
joestringer approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Seems like we should nominate this for backport at least to v1.11?

@aanm aanm merged commit c760948 into cilium:master Jan 17, 2022
@sayboras sayboras deleted the tam/helm-update-invalid-links branch January 19, 2022 10:31
@kkourt kkourt mentioned this pull request Jan 21, 2022
Merged
@kkourt kkourt added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Jan 25, 2022
@joestringer joestringer mentioned this pull request Feb 23, 2022
Merged
@craigbox craigbox mentioned this pull request Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@joestringer joestringer joestringer approved these changes

@kaworu kaworu kaworu approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/helm Impacts helm charts and user deployment experience backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sayboras @kaworu @joestringer @aanm @kkourt