ci: use a script for check-preflight-clusterrole.sh #20786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
ldelossa
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
ldelossa
force-pushed
the
ldelossa/dont-inline-clusterrole-precheck
branch
from
aae8840
to
f4b6b7c
Compare
sayboras
approved these changes
Aug 5, 2022
it's not convenient to have inline scripts in github actions, as we can't run the actions which fail a CI run locally. this commit moves the clusterrole preflight check into a script that can be ran locally before pushing the branch up. Signed-off-by: Louis DeLosSantos <louis.delos@isovalent.com>
ldelossa
force-pushed
the
ldelossa/dont-inline-clusterrole-precheck
branch
from
f4b6b7c
to
1569735
Compare
|
@sayboras I just force pushed the suggested |
aditighag
approved these changes
Aug 5, 2022
|
I don't think we need to run full CI tests since this does not touch the code. Marking ready to merge. |
ldelossa
added
the
ready-to-merge
nbusseneau
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's not convenient to have inline scripts in github actions, as we
can't run the actions which fail a CI run, locally.
this commit moves the clusterrole preflight check into a script that can
be ran locally before pushing the branch up.
Signed-off-by: Louis DeLosSantos louis.delos@isovalent.com