install: Support configuring metricsRelabelings on ServiceMonitors #21051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
chancez
force-pushed
the
pr/chancez/servicemonitor_relabelings
branch
from
1f14255
to
1ef5cb4
Compare
|
Not sure why BPF checks failed, I didn't touch anything that should be effected. |
|
Ah it's check patch disliking a misspelt word in my commit message. |
chancez
force-pushed
the
pr/chancez/servicemonitor_relabelings
branch
from
1ef5cb4
to
ad751ee
Compare
michi-covalent
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
michi-covalent
approved these changes
Aug 23, 2022
|
The Travis failure is legitimate: |
gandro
approved these changes
Aug 24, 2022
chancez
force-pushed
the
pr/chancez/servicemonitor_relabelings
branch
from
ad751ee
to
581d72a
Compare
|
Ah good catch. Missed that. Updated commit to update docs values. |
This allows adding or removing labels in metrics collected by Prometheus. Additionally, I removed the node relabeling in the hubble ServiceMonitor because this is automatically added by prometheus-operator already, so it was redundant and unnecessary for our ServiceMonitor to configure itself. Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
chancez
force-pushed
the
pr/chancez/servicemonitor_relabelings
branch
from
581d72a
to
318a8b0
Compare
qmonnet
approved these changes
Aug 24, 2022
tommyp1ckles
approved these changes
Aug 25, 2022
|
looks good |
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
Neither of the test failures seem relevant to these changes, merging. |
christarazi
added
backport-done/1.12
This was referenced Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows adding or removing or changing labels in metrics collected by
Prometheus.
Additionally, I removed the node relabeling in the hubble ServiceMonitor
because this is automatically added by prometheus-operator already, so
it was redundant and unecessary for our ServiceMonitor to configure
itself.