bgpv1: Clear announcement vars after server recreation #24304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We maintain a cache/shadow map for all advertisements we have made. During reconciliation we check the desired state against this shadow state which lives in the `PodCIDRAnnouncements` and `ServiceAnnouncements` variables. This works until the `preflightReconciler` decides to recreate the server, which happens if the router-id or the listen port changes. At this point the GoBGP route server is recreated which also clears the tables. But we forget to clear our shadow state as well. This causes any existing routes to not be added since the reconcilers think they are already there. Fixes: cilium#24069 Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
dylandreimerink
added
release-note/bug
2 tasks
YutaroHayakawa
approved these changes
Mar 13, 2023
|
We don't need to run full e2e tests for this change. This change is trivial and e2e tests don't use BGP CPlane for the tests. |
YutaroHayakawa
added
the
ready-to-merge
9 tasks
29 tasks
youngnick
added
backport-done/1.12
jibi
added
backport-done/1.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We maintain a cache/shadow map for all advertisements we have made. During reconciliation we check the desired state against this shadow state which lives in the
PodCIDRAnnouncementsandServiceAnnouncementsvariables.This works until the
preflightReconcilerdecides to recreate the server, which happens if the router-id or the listen port changes. At this point the GoBGP route server is recreated which also clears the tables. But we forget to clear our shadow state as well. This causes any existing routes to not be added since the reconcilers think they are already there.Fixes: #24069