Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ingress: add unit tests to test default ingressclass #29792

Merged
merged 1 commit into from
Dec 12, 2023
Merged

ingress: add unit tests to test default ingressclass #29792

merged 1 commit into from
Dec 12, 2023

Conversation

mhofstetter
Copy link
Member

@mhofstetter mhofstetter commented Dec 11, 2023 •
edited
Loading

This commit adds a unit-test that tests the use case of the Cilium IngressClass being the default or not.

Context: #28691

@mhofstetter
ingress: add unit tests to test default ingressclass
fbda085 
This commit adds a unit-test that tests the use case of the
Cilium IngressClass being the default or not.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter added kind/enhancement This would improve or streamline existing functionality. release-note/misc This PR makes changes that have no direct user impact. area/servicemesh GH issues or PRs regarding servicemesh feature/k8s-ingress labels Dec 11, 2023
@mhofstetter mhofstetter requested a review from a team as a code owner December 11, 2023 14:07
@mhofstetter
Copy link
Member Author

/test

@mhofstetter mhofstetter mentioned this pull request Dec 12, 2023
Closed
2 tasks
sayboras
sayboras approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ✔️

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 12, 2023
@sayboras sayboras added this pull request to the merge queue Dec 12, 2023
Merged via the queue into cilium:main with commit 7307f32 Dec 12, 2023
62 checks passed
@mhofstetter mhofstetter deleted the pr/mhofstetter/ingressclass-test branch December 12, 2023 12:13
@joestringer joestringer mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayboras sayboras sayboras approved these changes

Assignees
No one assigned
Labels
area/servicemesh GH issues or PRs regarding servicemesh feature/k8s-ingress kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhofstetter @sayboras